Changeset 295186 in webkit

Timestamp:

Jun 2, 2022, 11:45:35 PM (4 years ago)

Author:

Alan Coon

Message:

Cherry-pick 9a7e68adec7a. rdar://problem/93329781

Add logging when taking a process assertion synchronously
​https://bugs.webkit.org/show_bug.cgi?id=240334

Reviewed by Chris Dumez.

No observable change of behavior.

• UIProcess/ios/ProcessAssertionIOS.mm: (WebKit::ProcessAssertion::acquireSync):

Canonical link: ​https://commits.webkit.org/250580@main
git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@294222 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Location:

branches/safari-613-branch/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/ios/ProcessAssertionIOS.mm (modified) (2 diffs)

branches/safari-613-branch/Source/WebKit/ChangeLog

@@ +1 @@
+2022-05-16  Youenn Fablet  <youenn@apple.com>
+
+        Add logging when taking a process assertion synchronously
+        https://bugs.webkit.org/show_bug.cgi?id=240334
+
+        Reviewed by Chris Dumez.
+
+        No observable change of behavior.
+
+        * UIProcess/ios/ProcessAssertionIOS.mm:
+        (WebKit::ProcessAssertion::acquireSync):
+
 2022-04-14  Wenson Hsieh  <wenson_hsieh@apple.com>
 

branches/safari-613-branch/Source/WebKit/UIProcess/ios/ProcessAssertionIOS.mm

@@ -368 +368 @@
 void ProcessAssertion::acquireSync()
 {
+    RELEASE_LOG(ProcessSuspension, "%p - ProcessAssertion::acquireSync Trying to take RBS assertion '%{public}s' for process with PID=%d", this, m_reason.utf8().data(), m_pid);
+
     NSError *acquisitionError = nil;
     if (![m_rbsAssertion acquireWithError:&acquisitionError]) {
-        RELEASE_LOG_ERROR(ProcessSuspension, "%p - ProcessAssertion: Failed to acquire RBS assertion '%{public}s' for process with PID=%d, error: %{public}@", this, m_reason.utf8().data(), m_pid, acquisitionError);
+        RELEASE_LOG_ERROR(ProcessSuspension, "%p - ProcessAssertion::acquireSync Failed to acquire RBS assertion '%{public}s' for process with PID=%d, error: %{public}@", this, m_reason.utf8().data(), m_pid, acquisitionError);
         RunLoop::main().dispatch([weakThis = WeakPtr { *this }] {
             if (weakThis)
@@ -376 +378 @@
         });
     } else
-        RELEASE_LOG(ProcessSuspension, "%p - ProcessAssertion: Successfully took RBS assertion '%{public}s' for process with PID=%d", this, m_reason.utf8().data(), m_pid);
+        RELEASE_LOG(ProcessSuspension, "%p - ProcessAssertion::acquireSync Successfully took RBS assertion '%{public}s' for process with PID=%d", this, m_reason.utf8().data(), m_pid);
 }