Changeset 295273 in webkit

Timestamp:

Jun 5, 2022 5:04:13 PM (2 years ago)

Author:

Alan Bujtas

Message:

column-reverse content should take resolved flex box height into account when computing visual position
​https://bugs.webkit.org/show_bug.cgi?id=241313

Reviewed by Antti Koivisto.

When the flex box has resolvable height, use it as the anchor point to compute the column-reverse content's visual vertical position.

• Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp:

(WebCore::Layout::FlexFormattingContext::setFlexItemsGeometry):

Canonical link: ​https://commits.webkit.org/251319@main

File:

• trunk/Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp (modified) (1 diff)

trunk/Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp

@@ -265 +265 @@
             break;
         }
-        case FlexDirection::ColumnReverse:
+        case FlexDirection::ColumnReverse: {
+            auto visualBottom = constraints.logicalTop() + constraints.availableVerticalSpace().value_or(logicalWidth);
             borderBoxTopLeft = {
                 constraints.horizontal().logicalLeft + logicalFlexItem.top(),
-                constraints.logicalTop() + logicalWidth - logicalFlexItem.right() + flexItemGeometry.marginBefore()
+                visualBottom - logicalFlexItem.right() + flexItemGeometry.marginBefore()
             };
             break;
+        }
         default:
             ASSERT_NOT_REACHED();