Changeset 295282 in webkit

Timestamp:

Jun 6, 2022 6:08:35 AM (2 years ago)

Author:

Alan Bujtas

Message:

Populate canUseForFlexLayout with unsupported styles and content
​https://bugs.webkit.org/show_bug.cgi?id=241323

Reviewed by Tim Nguyen.

This is in preparation for being able to run WPT tests (filter out unsupported content).

• Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp:

(WebCore::LayoutIntegration::canUseForFlexLayout):

Canonical link: ​https://commits.webkit.org/251328@main

File:

• trunk/Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp (modified) (1 diff)

trunk/Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp

@@ -679 +679 @@
     if (!flexBox.document().settings().flexFormattingContextIntegrationEnabled())
         return false;
-    ASSERT_NOT_IMPLEMENTED_YET();
-    return false;
-}
-
-}
-}
-
-#endif
+
+    auto& flexBoxStyle = flexBox.style();
+    if (!flexBoxStyle.isHorizontalWritingMode() || !flexBoxStyle.isLeftToRightDirection())
+        return false;
+    if (flexBoxStyle.flexWrap() == FlexWrap::Reverse)
+        return false;
+    if (flexBoxStyle.alignItems().position() == ItemPosition::Baseline)
+        return false;
+    if (flexBoxStyle.alignContent().position() != ContentPosition::Normal || flexBoxStyle.alignContent().distribution() != ContentDistribution::Default || flexBoxStyle.alignContent().overflow() != OverflowAlignment::Default)
+        return false;
+    if (!flexBoxStyle.rowGap().isNormal() || !flexBoxStyle.columnGap().isNormal())
+        return false;
+
+    for (auto& flexItem : childrenOfType<RenderElement>(flexBox)) {
+        if (!is<RenderBox>(flexItem))
+            return false;
+        if (flexItem.isFloating() || flexItem.isOutOfFlowPositioned())
+            return false;
+        if (flexItem.isSVGRootOrLegacySVGRoot())
+            return false;
+        auto& flexItemStyle = flexItem.style();
+        if (!flexItemStyle.maxWidth().isUndefined() || !flexItemStyle.maxHeight().isUndefined())
+            return false;
+        if (flexItem.hasIntrinsicAspectRatio() || flexItemStyle.hasAspectRatio())
+            return false;
+    }
+    return true;
+}
+
+}
+}
+
+#endif