⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Changeset 295696 in webkit


Ignore:
Timestamp:
Jun 21, 2022, 3:39:28 PM (4 years ago)
Author:
commit-queue@webkit.org
Message:

Fix spelling error identifer -> identifier.
​https://bugs.webkit.org/show_bug.cgi?id=241787

Patch by Youssef Soliman <​youssefdevelops@gmail.com> on 2022-06-21
Reviewed by Jonathan Bedard and Ross Kirsling.

Across multiple files, the word "identifier" is misspelled as "identifer"

  • Source/WebCore/Modules/filesystemaccess/FileSystemHandleCloseScope.h:

(WebCore::FileSystemHandleCloseScope::FileSystemHandleCloseScope):

  • Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:

(GenerateDeletePropertyCommon):

  • Source/WebCore/bindings/scripts/test/JS/JSTestNamedDeleterNoIdentifier.cpp:

(WebCore::JSTestNamedDeleterNoIdentifier::deleteProperty):
(WebCore::JSTestNamedDeleterNoIdentifier::deletePropertyByIndex):

  • Source/WebCore/bindings/scripts/test/JS/JSTestNamedDeleterThrowingException.cpp:

(WebCore::JSTestNamedDeleterThrowingException::deleteProperty):
(WebCore::JSTestNamedDeleterThrowingException::deletePropertyByIndex):

  • Source/WebCore/bindings/scripts/test/JS/JSTestNamedDeleterWithIndexedGetter.cpp:

(WebCore::JSTestNamedDeleterWithIndexedGetter::deleteProperty):

  • Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp:

(WebKit::RemoteRenderingBackend::prepareLayerBuffersForDisplay):

  • Source/WebKit/Shared/ObjectIdentifierReferenceTracker.h:
  • Source/WebKit/UIProcess/API/APIContentWorld.cpp:

(API::ContentWorld::worldForIdentifier):

  • Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp:

(WebKit::RemoteRenderingBackendProxy::ensureGPUProcessConnection):

  • Source/WebKit/WebProcess/Storage/WebSWContextManagerConnection.messages.in:
  • Source/WebKit/webpushd/PushClientConnection.mm:

(WebPushD::ClientConnection::broadcastDebugMessage):

  • Tools/MiniBrowser/mac/WK2BrowserWindowController.m:

(-[WK2BrowserWindowController updateTitle:]):

  • Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/init.py:
  • Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/revert.py:

(Revert.parser):

  • Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/squash.py:

(Squash.parser):

Canonical link: ​https://commits.webkit.org/251701@main

Location:
trunk
Files:
15 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebCore/Modules/filesystemaccess/FileSystemHandleCloseScope.h

    r287156 r295696  
    5454
    5555private:
    56     FileSystemHandleCloseScope(FileSystemHandleIdentifier identifer, bool isDirectory, FileSystemStorageConnection& connection)
    57         : m_identifier(identifer)
     56    FileSystemHandleCloseScope(FileSystemHandleIdentifier identifier, bool isDirectory, FileSystemStorageConnection& connection)
     57        : m_identifier(identifier)
    5858        , m_isDirectory(isDirectory)
    5959        , m_connection(Ref { connection })

  • trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm

    r295270 r295696  
    15291529    if (!$operation->name) {
    15301530        push(@$outputArray, "        using ReturnType = decltype($functionCall);\n");
    1531         push(@$outputArray, "        static_assert(std::is_same_v<ReturnType, ExceptionOr<bool>> || std::is_same_v<ReturnType, bool>, \"The implementation of named deleters without an identifer must return either bool or ExceptionOr<bool>.\");\n");
     1531        push(@$outputArray, "        static_assert(std::is_same_v<ReturnType, ExceptionOr<bool>> || std::is_same_v<ReturnType, bool>, \"The implementation of named deleters without an identifier must return either bool or ExceptionOr<bool>.\");\n");
    15321532    }
    15331533

  • trunk/Source/WebCore/bindings/scripts/test/JS/JSTestNamedDeleterNoIdentifier.cpp

    r294346 r295696  
    210210    if (isVisibleNamedProperty<LegacyOverrideBuiltIns::No>(*lexicalGlobalObject, thisObject, propertyName)) {
    211211        using ReturnType = decltype(impl.deleteNamedProperty(propertyNameToString(propertyName)));
    212         static_assert(std::is_same_v<ReturnType, ExceptionOr<bool>> || std::is_same_v<ReturnType, bool>, "The implementation of named deleters without an identifer must return either bool or ExceptionOr<bool>.");
     212        static_assert(std::is_same_v<ReturnType, ExceptionOr<bool>> || std::is_same_v<ReturnType, bool>, "The implementation of named deleters without an identifier must return either bool or ExceptionOr<bool>.");
    213213        return performLegacyPlatformObjectDeleteOperation(*lexicalGlobalObject, [&] { return impl.deleteNamedProperty(propertyNameToString(propertyName)); });
    214214    }
    … …  
    224224    if (isVisibleNamedProperty<LegacyOverrideBuiltIns::No>(*lexicalGlobalObject, thisObject, propertyName)) {
    225225        using ReturnType = decltype(impl.deleteNamedProperty(propertyNameToString(propertyName)));
    226         static_assert(std::is_same_v<ReturnType, ExceptionOr<bool>> || std::is_same_v<ReturnType, bool>, "The implementation of named deleters without an identifer must return either bool or ExceptionOr<bool>.");
     226        static_assert(std::is_same_v<ReturnType, ExceptionOr<bool>> || std::is_same_v<ReturnType, bool>, "The implementation of named deleters without an identifier must return either bool or ExceptionOr<bool>.");
    227227        return performLegacyPlatformObjectDeleteOperation(*lexicalGlobalObject, [&] { return impl.deleteNamedProperty(propertyNameToString(propertyName)); });
    228228    }

  • trunk/Source/WebCore/bindings/scripts/test/JS/JSTestNamedDeleterThrowingException.cpp

    r294346 r295696  
    210210    if (isVisibleNamedProperty<LegacyOverrideBuiltIns::No>(*lexicalGlobalObject, thisObject, propertyName)) {
    211211        using ReturnType = decltype(impl.deleteNamedProperty(propertyNameToString(propertyName)));
    212         static_assert(std::is_same_v<ReturnType, ExceptionOr<bool>> || std::is_same_v<ReturnType, bool>, "The implementation of named deleters without an identifer must return either bool or ExceptionOr<bool>.");
     212        static_assert(std::is_same_v<ReturnType, ExceptionOr<bool>> || std::is_same_v<ReturnType, bool>, "The implementation of named deleters without an identifier must return either bool or ExceptionOr<bool>.");
    213213        return performLegacyPlatformObjectDeleteOperation(*lexicalGlobalObject, [&] { return impl.deleteNamedProperty(propertyNameToString(propertyName)); });
    214214    }
    … …  
    224224    if (isVisibleNamedProperty<LegacyOverrideBuiltIns::No>(*lexicalGlobalObject, thisObject, propertyName)) {
    225225        using ReturnType = decltype(impl.deleteNamedProperty(propertyNameToString(propertyName)));
    226         static_assert(std::is_same_v<ReturnType, ExceptionOr<bool>> || std::is_same_v<ReturnType, bool>, "The implementation of named deleters without an identifer must return either bool or ExceptionOr<bool>.");
     226        static_assert(std::is_same_v<ReturnType, ExceptionOr<bool>> || std::is_same_v<ReturnType, bool>, "The implementation of named deleters without an identifier must return either bool or ExceptionOr<bool>.");
    227227        return performLegacyPlatformObjectDeleteOperation(*lexicalGlobalObject, [&] { return impl.deleteNamedProperty(propertyNameToString(propertyName)); });
    228228    }

  • trunk/Source/WebCore/bindings/scripts/test/JS/JSTestNamedDeleterWithIndexedGetter.cpp

    r294346 r295696  
    233233    if (isVisibleNamedProperty<LegacyOverrideBuiltIns::No>(*lexicalGlobalObject, thisObject, propertyName)) {
    234234        using ReturnType = decltype(impl.deleteNamedProperty(propertyNameToString(propertyName)));
    235         static_assert(std::is_same_v<ReturnType, ExceptionOr<bool>> || std::is_same_v<ReturnType, bool>, "The implementation of named deleters without an identifer must return either bool or ExceptionOr<bool>.");
     235        static_assert(std::is_same_v<ReturnType, ExceptionOr<bool>> || std::is_same_v<ReturnType, bool>, "The implementation of named deleters without an identifier must return either bool or ExceptionOr<bool>.");
    236236        return performLegacyPlatformObjectDeleteOperation(*lexicalGlobalObject, [&] { return impl.deleteNamedProperty(propertyNameToString(propertyName)); });
    237237    }

  • trunk/Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp

    r295621 r295696  
    443443    };
    444444
    445     auto bufferIdentifer = [](ImageBuffer* buffer) -> std::optional<RenderingResourceIdentifier> {
     445    auto bufferIdentifier = [](ImageBuffer* buffer) -> std::optional<RenderingResourceIdentifier> {
    446446        if (!buffer)
    447447            return std::nullopt;
    … …  
    469469        // No swap necessary, but we do need to return the front buffer handle.
    470470        outputData.frontBufferHandle = handleFromBuffer(*frontBuffer);
    471         outputData.bufferSet = BufferIdentifierSet { bufferIdentifer(frontBuffer), bufferIdentifer(backBuffer), bufferIdentifer(secondaryBackBuffer) };
     471        outputData.bufferSet = BufferIdentifierSet { bufferIdentifier(frontBuffer), bufferIdentifier(backBuffer), bufferIdentifier(secondaryBackBuffer) };
    472472        outputData.displayRequirement = SwapBuffersDisplayRequirement::NeedsNoDisplay;
    473473        return;
    … …  
    489489    std::swap(frontBuffer, backBuffer);
    490490
    491     outputData.bufferSet = BufferIdentifierSet { bufferIdentifer(frontBuffer), bufferIdentifer(backBuffer), bufferIdentifer(secondaryBackBuffer) };
     491    outputData.bufferSet = BufferIdentifierSet { bufferIdentifier(frontBuffer), bufferIdentifier(backBuffer), bufferIdentifier(secondaryBackBuffer) };
    492492    if (frontBuffer) {
    493493        auto previousState = frontBuffer->setNonVolatile();

  • trunk/Source/WebKit/Shared/ObjectIdentifierReferenceTracker.h

    r289622 r295696  
    148148};
    149149
    150 // Class to generate read and write references to an ObjectIdentifer.
     150// Class to generate read and write references to an ObjectIdentifier.
    151151template<typename T>
    152152class ObjectIdentifierReferenceTracker {

  • trunk/Source/WebKit/UIProcess/API/APIContentWorld.cpp

    r282882 r295696  
    4646}
    4747
    48 ContentWorld* ContentWorld::worldForIdentifier(WebKit::ContentWorldIdentifier identifer)
     48ContentWorld* ContentWorld::worldForIdentifier(WebKit::ContentWorldIdentifier identifier)
    4949{
    50     return sharedWorldIdentifierMap().get(identifer);
     50    return sharedWorldIdentifierMap().get(identifier);
    5151}
    5252

  • trunk/Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp

    r295621 r295696  
    7878
    7979        static constexpr auto connectionBufferSize = 1 << 21;
    80         auto [streamConnection, dedicatedConnectionClientIdentifer] = IPC::StreamClientConnection::createWithDedicatedConnection(*this, connectionBufferSize);
     80        auto [streamConnection, dedicatedConnectionClientIdentifier] = IPC::StreamClientConnection::createWithDedicatedConnection(*this, connectionBufferSize);
    8181        m_streamConnection = WTFMove(streamConnection);
    8282        m_streamConnection->open();
    83         m_gpuProcessConnection->connection().send(Messages::GPUConnectionToWebProcess::CreateRenderingBackend(m_parameters, dedicatedConnectionClientIdentifer, m_streamConnection->streamBuffer()), 0, IPC::SendOption::DispatchMessageEvenWhenWaitingForSyncReply);
     83        m_gpuProcessConnection->connection().send(Messages::GPUConnectionToWebProcess::CreateRenderingBackend(m_parameters, dedicatedConnectionClientIdentifier, m_streamConnection->streamBuffer()), 0, IPC::SendOption::DispatchMessageEvenWhenWaitingForSyncReply);
    8484    }
    8585    return *m_gpuProcessConnection;

  • trunk/Source/WebKit/WebProcess/Storage/WebSWContextManagerConnection.messages.in

    r295488 r295696  
    2626    InstallServiceWorker(struct WebCore::ServiceWorkerContextData contextData, struct WebCore::ServiceWorkerData workerData, String userAgent, enum:bool WebCore::WorkerThreadMode workerThreadMode)
    2727    UpdateAppInitiatedValue(WebCore::ServiceWorkerIdentifier serviceWorkerIdentifier, enum:bool WebCore::LastNavigationWasAppInitiated lastNavigationWasAppInitiated)
    28     StartFetch(WebCore::SWServerConnectionIdentifier serverConnectionIdentifier, WebCore::ServiceWorkerIdentifier serviceWorkerIdentifier, WebCore::FetchIdentifier fetchIdentifier, WebCore::ResourceRequest request, struct WebCore::FetchOptions options, IPC::FormDataReference requestBody, String referrer, bool isServiceWorkerNavigationPreloadEnabled, String clientIdentifer, String resutlingClientIdentifier)
     28    StartFetch(WebCore::SWServerConnectionIdentifier serverConnectionIdentifier, WebCore::ServiceWorkerIdentifier serviceWorkerIdentifier, WebCore::FetchIdentifier fetchIdentifier, WebCore::ResourceRequest request, struct WebCore::FetchOptions options, IPC::FormDataReference requestBody, String referrer, bool isServiceWorkerNavigationPreloadEnabled, String clientIdentifier, String resutlingClientIdentifier)
    2929    CancelFetch(WebCore::SWServerConnectionIdentifier serverConnectionIdentifier, WebCore::ServiceWorkerIdentifier serviceWorkerIdentifier, WebCore::FetchIdentifier fetchIdentifier)
    3030    ContinueDidReceiveFetchResponse(WebCore::SWServerConnectionIdentifier serverConnectionIdentifier, WebCore::ServiceWorkerIdentifier serviceWorkerIdentifier, WebCore::FetchIdentifier fetchIdentifier)

  • trunk/Source/WebKit/webpushd/PushClientConnection.mm

    r295270 r295696  
    135135{
    136136    String messageIdentifier;
    137     auto signingIdentifer = hostAppCodeSigningIdentifier();
    138     if (signingIdentifer.isEmpty())
     137    auto signingIdentifier = hostAppCodeSigningIdentifier();
     138    if (signingIdentifier.isEmpty())
    139139        messageIdentifier = makeString("[(0x", hex(reinterpret_cast<uint64_t>(m_xpcConnection.get()), WTF::HexConversionMode::Lowercase), ") (", String::number(identifier()), " )] ");
    140140    else
    141         messageIdentifier = makeString("[", signingIdentifer, " (", String::number(identifier()), ")] ");
     141        messageIdentifier = makeString("[", signingIdentifier, " (", String::number(identifier()), ")] ");
    142142
    143143    Daemon::singleton().broadcastDebugMessage(makeString(messageIdentifier, message));

  • trunk/Tools/MiniBrowser/mac/WK2BrowserWindowController.m

    r294285 r295696  
    556556#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 110000
    557557    self.window.title = title;
    558     pid_t gpuProcessIdentifer = _webView._gpuProcessIdentifier;
    559     if (gpuProcessIdentifer)
    560         self.window.subtitle = [NSString stringWithFormat:@"[WK2 wp %d gpup %d]%@%@", _webView._webProcessIdentifier, gpuProcessIdentifer, _isPrivateBrowsingWindow ? @" 🙈" : @"", _webView._editable ? @" ✏️" : @""];
     558    pid_t gpuProcessIdentifier = _webView._gpuProcessIdentifier;
     559    if (gpuProcessIdentifier)
     560        self.window.subtitle = [NSString stringWithFormat:@"[WK2 wp %d gpup %d]%@%@", _webView._webProcessIdentifier, gpuProcessIdentifier, _isPrivateBrowsingWindow ? @" 🙈" : @"", _webView._editable ? @" ✏️" : @""];
    561561    else
    562562        self.window.subtitle = [NSString stringWithFormat:@"[WK2 %d]%@%@", _webView._webProcessIdentifier, _isPrivateBrowsingWindow ? @" 🙈" : @"", _webView._editable ? @" ✏️" : @""];

  • trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/__init__.py

    r295388 r295696  
    6060    parser = argparse.ArgumentParser(
    6161        description='Custom git tooling from the WebKit team to interact with a ' +
    62                     'repository using identifers',
     62                    'repository using identifiers',
    6363    )
    6464    arguments.LoggingGroup(

  • trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/revert.py

    r294376 r295696  
    4949        parser.add_argument(
    5050            'commit',
    51             help='git hash, svn revision or identifer you want to revert'
     51            help='git hash, svn revision or identifier you want to revert'
    5252        )
    5353

  • trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/squash.py

    r295388 r295696  
    6262            '--base-commit',
    6363            dest='base_commit',
    64             help='git hash, svn revision or identifer for the base commit that you want to squash to (merged commit will not include this commit)',
     64            help='git hash, svn revision or identifier for the base commit that you want to squash to (merged commit will not include this commit)',
    6565            default=None,
    6666        )
Note: See TracChangeset for help on using the changeset viewer.