Changeset 295699 in webkit

Timestamp:

Jun 21, 2022, 4:22:07 PM (4 years ago)

Author:

Patrick Angle

Message:

Web Inspector: Fonts details sidebar in Elements tab has empty space for filter bar
​https://bugs.webkit.org/show_bug.cgi?id=241817
rdar://problem/95634156

Reviewed by Devin Rousso.

As pointed out by Devin, passing undefined to toggle here acts as if we didn't pass a value, not as a falsy value.

• Source/WebInspectorUI/UserInterface/Views/GeneralStyleDetailsSidebarPanel.js:

(WI.GeneralStyleDetailsSidebarPanel.prototype._showPanel):

Canonical link: ​https://commits.webkit.org/251703@main

File:

• trunk/Source/WebInspectorUI/UserInterface/Views/GeneralStyleDetailsSidebarPanel.js (modified) (1 diff)

trunk/Source/WebInspectorUI/UserInterface/Views/GeneralStyleDetailsSidebarPanel.js

@@ -214 +214 @@
     {
         this.contentView.addSubview(this._panel);
-        this.contentView.element.classList.toggle("has-filter-bar", this._filterBar);
+        this.contentView.element.classList.toggle("has-filter-bar", !!this._filterBar);
         if (this._filterBar)
             this.contentView.element.classList.toggle(WI.GeneralStyleDetailsSidebarPanel.FilterInProgressClassName, this._filterBar.hasActiveFilters());