Changeset 295737 in webkit

Timestamp:

Jun 22, 2022, 10:57:21 AM (4 years ago)

Author:

commit-queue@webkit.org

Message:

REGRESSION (r293506): [ iOS ][ macOS ] imported/w3c/web-platform-tests/service-workers/service-worker/registration-updateviacache.https.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=240074
rdar://problem/92742526

Patch by Youenn Fablet <​youennf@gmail.com> on 2022-06-22
Reviewed by Chris Dumez.

Before r293506, we were refreshing the imported scripts from network process only.
We are now correctly refreshing them from the caller of update.
This makes it possible to load the same scripts from various processes (web process, service worker process), which have different memory caches.
The failure happened due to the fact that different subtests were importing the same subscript with various options.
This triggered storing the subscript in different memory caches.
Some tests expect cache to kick in and expect in that case to have the same resource.
If the cache kicks in, but on different memory caches, we end up with different resources.
To prevent this in the test, we simply append the test name to each subscript import.

• LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/resources/update-max-aged-worker.py:

(main):

• LayoutTests/platform/mac/TestExpectations:

Canonical link: ​https://commits.webkit.org/251742@main

Location:

trunk/LayoutTests

Files:

• imported/w3c/web-platform-tests/service-workers/service-worker/resources/update-max-aged-worker.py (modified) (1 diff)
• platform/mac/TestExpectations (modified) (1 diff)

trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/resources/update-max-aged-worker.py

@@ -14 +14 @@
         const mainTime = {time:8f};
         const testName = {test};
-        importScripts('update-max-aged-worker-imported-script.py');
+        importScripts('update-max-aged-worker-imported-script.py?test={test}');
 
         addEventListener('message', event => {{

trunk/LayoutTests/platform/mac/TestExpectations

@@ -2290 +2290 @@
 webkit.org/b/239990 css3/calc/transitions-dependent.html [ Pass Failure ]
 
-webkit.org/b/240074 imported/w3c/web-platform-tests/service-workers/service-worker/registration-updateviacache.https.html [ Pass Failure ]
-
 webkit.org/b/231298 accessibility/mac/selection-sync.html [ Skip ] # Timeout