Changeset 295765 in webkit

Timestamp:

Jun 22, 2022 7:54:49 PM (23 months ago)

Author:

Alan Bujtas

Message:

Adding padding on a horizontal scroller prevents last item from being fully viewable
​https://bugs.webkit.org/show_bug.cgi?id=236142
<rdar://problem/88495053>

Reviewed by Simon Fraser.

Flex box's padding end should be taken into account when computing scrollable overflow.

• LayoutTests/fast/overflow/flex-box-overflow-with-padding-end-expected.html: Added.
• LayoutTests/fast/overflow/flex-box-overflow-with-padding-end.html: Added.
• Source/WebCore/rendering/RenderBlock.cpp:

(WebCore::RenderBlock::computeOverflow):

css3/flexbox/overflow-and-padding.html: matching Blink.

Canonical link: ​https://commits.webkit.org/251770@main

Location:

trunk

Files:

• LayoutTests/css3/flexbox/overflow-and-padding-expected.txt (modified) (1 diff)
• LayoutTests/fast/overflow/flex-box-overflow-with-padding-end-expected.html (added)
• LayoutTests/fast/overflow/flex-box-overflow-with-padding-end.html (added)
• Source/WebCore/rendering/RenderBlock.cpp (modified) (1 diff)

trunk/LayoutTests/css3/flexbox/overflow-and-padding-expected.txt

@@ -1 +1 @@
 
-PASS #scrollable 1
+FAIL #scrollable 1 assert_equals:
+<div id="scrollable" data-expected-scroll-height="500" data-expected-scroll-width="400">
+    <div id="item"></div>
+</div>
+scrollWidth expected 400 but got 500
 Tests that padding bottom on a flexbox works in the face of overflowing content. Padding-right does not work. This matches the Blink/WebKit display:block behavior. Unfortunately, IE and Gecko both lose the padding bottom and the padding right.
 

trunk/Source/WebCore/rendering/RenderBlock.cpp

@@ -696 +696 @@
             if (!paddingEnd())
                 return;
-            // FIXME: Expand it to non-grid cases when applicable.
-            if (!is<RenderGrid>(*this))
+            // FIXME: Expand it to non-grid/flex cases when applicable.
+            if (!is<RenderGrid>(*this) && !is<RenderFlexibleBox>(*this))
                 return;