Changeset 29667 in webkit


Ignore:
Timestamp:
Jan 19, 2008, 2:12:48 AM (17 years ago)
Author:
mitz@apple.com
Message:

WebCore:

Reviewed by Maciej Stachowiak.

  • fix <rdar://problem/5645813> CrashTracer: [USER] 6 crashes in Safari at com.apple.WebCore: WebCore::RenderBox::destroy + 116

Test: editing/selection/inconsistent-in-removeChildNode.html

  • editing/SelectionController.cpp: (WebCore::SelectionController::nodeWillBeRemoved): If the selection base or extent are not visible any more, adjust the selection.

LayoutTests:

Reviewed by Maciej Stachowiak.

  • test and updated results for <rdar://problem/5645813> CrashTracer: [USER] 6 crashes in Safari at com.apple.WebCore: WebCore::RenderBox::destroy + 116
  • editing/selection/inconsistent-in-removeChildNode.html: Added.
  • platform/mac-leopard/editing/pasteboard/paste-RTFD-expected.txt:
  • platform/mac-leopard/editing/selection: Added.
  • platform/mac-leopard/editing/selection/inconsistent-in-removeChildNode-expected.checksum: Added.
  • platform/mac-leopard/editing/selection/inconsistent-in-removeChildNode-expected.png: Added.
  • platform/mac/editing/deleting/collapse-whitespace-3587601-fix-expected.txt:
  • platform/mac/editing/deleting/delete-3608462-fix-expected.txt:
  • platform/mac/editing/deleting/delete-4083333-fix-expected.txt:
  • platform/mac/editing/deleting/delete-leading-ws-001-expected.txt:
  • platform/mac/editing/deleting/delete-line-011-expected.txt:
  • platform/mac/editing/execCommand/find-after-replace-expected.txt:
  • platform/mac/editing/execCommand/paste-1-expected.txt:
  • platform/mac/editing/execCommand/paste-2-expected.txt:
  • platform/mac/editing/pasteboard/emacs-ctrl-k-y-001-expected.txt:
  • platform/mac/editing/selection/inconsistent-in-removeChildNode-expected.txt: Added.
  • platform/mac/editing/selection/move-between-blocks-no-001-expected.txt:
  • platform/mac/editing/selection/replace-selection-1-expected.txt:
  • platform/mac/editing/style/remove-underline-across-paragraph-expected.txt:
  • platform/mac/editing/style/remove-underline-across-paragraph-in-bold-expected.txt:
  • platform/mac/editing/style/remove-underline-after-paragraph-in-bold-expected.txt:
  • platform/mac/editing/style/remove-underline-expected.txt:
  • platform/mac/editing/style/remove-underline-in-bold-expected.txt:
  • platform/mac/editing/style/unbold-in-bold-expected.txt:
Location:
trunk
Files:
5 added
21 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r29663 r29667  
     12008-01-19  Dan Bernstein  <mitz@apple.com>
     2
     3        Reviewed by Maciej Stachowiak.
     4
     5        - test and updated results for <rdar://problem/5645813> CrashTracer: [USER] 6 crashes in Safari at com.apple.WebCore: WebCore::RenderBox::destroy + 116
     6
     7        * editing/selection/inconsistent-in-removeChildNode.html: Added.
     8        * platform/mac-leopard/editing/pasteboard/paste-RTFD-expected.txt:
     9        * platform/mac-leopard/editing/selection: Added.
     10        * platform/mac-leopard/editing/selection/inconsistent-in-removeChildNode-expected.checksum: Added.
     11        * platform/mac-leopard/editing/selection/inconsistent-in-removeChildNode-expected.png: Added.
     12        * platform/mac/editing/deleting/collapse-whitespace-3587601-fix-expected.txt:
     13        * platform/mac/editing/deleting/delete-3608462-fix-expected.txt:
     14        * platform/mac/editing/deleting/delete-4083333-fix-expected.txt:
     15        * platform/mac/editing/deleting/delete-leading-ws-001-expected.txt:
     16        * platform/mac/editing/deleting/delete-line-011-expected.txt:
     17        * platform/mac/editing/execCommand/find-after-replace-expected.txt:
     18        * platform/mac/editing/execCommand/paste-1-expected.txt:
     19        * platform/mac/editing/execCommand/paste-2-expected.txt:
     20        * platform/mac/editing/pasteboard/emacs-ctrl-k-y-001-expected.txt:
     21        * platform/mac/editing/selection/inconsistent-in-removeChildNode-expected.txt: Added.
     22        * platform/mac/editing/selection/move-between-blocks-no-001-expected.txt:
     23        * platform/mac/editing/selection/replace-selection-1-expected.txt:
     24        * platform/mac/editing/style/remove-underline-across-paragraph-expected.txt:
     25        * platform/mac/editing/style/remove-underline-across-paragraph-in-bold-expected.txt:
     26        * platform/mac/editing/style/remove-underline-after-paragraph-in-bold-expected.txt:
     27        * platform/mac/editing/style/remove-underline-expected.txt:
     28        * platform/mac/editing/style/remove-underline-in-bold-expected.txt:
     29        * platform/mac/editing/style/unbold-in-bold-expected.txt:
     30
    1312008-01-18  Adele Peterson  <adele@apple.com>
    232

  • trunk/LayoutTests/platform/mac-leopard/editing/pasteboard/paste-RTFD-expected.txt

    r29424 r29667  
    33EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
    44EDITING DELEGATE: shouldInsertNode:#document-fragment replacingDOMRange:range from 0 of DIV > BODY > HTML > #document to 0 of DIV > BODY > HTML > #document givenAction:WebViewInsertActionPasted
    5 EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 0 of DIV > BODY > HTML > #document to 0 of DIV > BODY > HTML > #document toDOMRange:range from 0 of P > DIV > BODY > HTML > #document to 0 of P > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
     5EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 0 of P > DIV > BODY > HTML > #document to 0 of P > DIV > BODY > HTML > #document toDOMRange:range from 0 of P > DIV > BODY > HTML > #document to 0 of P > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
    66EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
    77EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification

  • trunk/LayoutTests/platform/mac/editing/deleting/collapse-whitespace-3587601-fix-expected.txt

    r25970 r29667  
    1212EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
    1313EDITING DELEGATE: shouldDeleteDOMRange:range from 4 of #text > SPAN > DIV > BODY > HTML > #document to 5 of #text > SPAN > DIV > BODY > HTML > #document
    14 EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 4 of #text > SPAN > DIV > BODY > HTML > #document to 4 of #text > SPAN > DIV > BODY > HTML > #document toDOMRange:range from 4 of #text > SPAN > DIV > BODY > HTML > #document to 4 of #text > SPAN > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
    15 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
    1614EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification
    1715EDITING DELEGATE: shouldDeleteDOMRange:range from 3 of #text > SPAN > DIV > BODY > HTML > #document to 4 of #text > SPAN > DIV > BODY > HTML > #document

  • trunk/LayoutTests/platform/mac/editing/deleting/delete-3608462-fix-expected.txt

    r25970 r29667  
    1414EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
    1515EDITING DELEGATE: shouldDeleteDOMRange:range from 3 of #text > SPAN > DIV > BODY > HTML > #document to 4 of #text > SPAN > DIV > BODY > HTML > #document
    16 EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 3 of #text > SPAN > DIV > BODY > HTML > #document to 3 of #text > SPAN > DIV > BODY > HTML > #document toDOMRange:range from 3 of #text > SPAN > DIV > BODY > HTML > #document to 3 of #text > SPAN > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
    17 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
    1816EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification
    1917EDITING DELEGATE: shouldDeleteDOMRange:range from 2 of #text > SPAN > DIV > BODY > HTML > #document to 3 of #text > SPAN > DIV > BODY > HTML > #document

  • trunk/LayoutTests/platform/mac/editing/deleting/delete-4083333-fix-expected.txt

    r25970 r29667  
    44EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
    55EDITING DELEGATE: shouldDeleteDOMRange:range from 3 of #text > A > SPAN > DIV > BODY > HTML > #document to 4 of #text > A > SPAN > DIV > BODY > HTML > #document
    6 EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 3 of #text > A > SPAN > DIV > BODY > HTML > #document to 3 of #text > A > SPAN > DIV > BODY > HTML > #document toDOMRange:range from 3 of #text > A > SPAN > DIV > BODY > HTML > #document to 3 of #text > A > SPAN > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
    7 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
    86EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification
    97layer at (0,0) size 800x600

  • trunk/LayoutTests/platform/mac/editing/deleting/delete-leading-ws-001-expected.txt

    r25970 r29667  
    88EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
    99EDITING DELEGATE: shouldDeleteDOMRange:range from 4 of #text > SPAN > DIV > BODY > HTML > #document to 7 of #text > SPAN > DIV > BODY > HTML > #document
    10 EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 2 of #text > SPAN > DIV > BODY > HTML > #document to 2 of #text > SPAN > DIV > BODY > HTML > #document toDOMRange:range from 2 of #text > SPAN > DIV > BODY > HTML > #document to 2 of #text > SPAN > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
     10EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 1 of #text > SPAN > DIV > BODY > HTML > #document to 1 of #text > SPAN > DIV > BODY > HTML > #document toDOMRange:range from 2 of #text > SPAN > DIV > BODY > HTML > #document to 2 of #text > SPAN > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
    1111EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
    1212EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification

  • trunk/LayoutTests/platform/mac/editing/deleting/delete-line-011-expected.txt

    r25970 r29667  
    2525EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
    2626EDITING DELEGATE: shouldDeleteDOMRange:range from 10 of #text > DIV > BODY > HTML > #document to 0 of DIV > BODY > HTML > #document
    27 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
    28 EDITING DELEGATE: shouldChangeSelectedDOMRange:(null) toDOMRange:range from 10 of #text > DIV > BODY > HTML > #document to 10 of #text > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
    29 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
    3027EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification
    3128layer at (0,0) size 800x600

  • trunk/LayoutTests/platform/mac/editing/execCommand/find-after-replace-expected.txt

    r25970 r29667  
    77EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
    88EDITING DELEGATE: shouldInsertNode:#document-fragment replacingDOMRange:range from 4 of #text > BODY > HTML > #document to 5 of #text > BODY > HTML > #document givenAction:WebViewInsertActionPasted
    9 EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 4 of #text > BODY > HTML > #document to 0 of #text > BODY > HTML > #document toDOMRange:range from 3 of #text > BODY > HTML > #document to 3 of #text > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
     9EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 4 of #text > BODY > HTML > #document to 4 of #text > BODY > HTML > #document toDOMRange:range from 3 of #text > BODY > HTML > #document to 3 of #text > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
    1010EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
    1111EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification

  • trunk/LayoutTests/platform/mac/editing/execCommand/paste-1-expected.txt

    r25970 r29667  
    55EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
    66EDITING DELEGATE: shouldDeleteDOMRange:range from 8 of #text > BODY > HTML > #document to 11 of #text > BODY > HTML > #document
    7 EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 7 of #text > BODY > HTML > #document to 7 of #text > BODY > HTML > #document toDOMRange:range from 7 of #text > BODY > HTML > #document to 7 of #text > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
    8 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
    97EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification
    108EDITING DELEGATE: shouldInsertNode:#document-fragment replacingDOMRange:range from 7 of #text > BODY > HTML > #document to 7 of #text > BODY > HTML > #document givenAction:WebViewInsertActionPasted

  • trunk/LayoutTests/platform/mac/editing/execCommand/paste-2-expected.txt

    r25970 r29667  
    55EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
    66EDITING DELEGATE: shouldDeleteDOMRange:range from 8 of #text > BODY > HTML > #document to 11 of #text > BODY > HTML > #document
    7 EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 7 of #text > BODY > HTML > #document to 7 of #text > BODY > HTML > #document toDOMRange:range from 7 of #text > BODY > HTML > #document to 7 of #text > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
    8 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
    97EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification
    108EDITING DELEGATE: shouldInsertNode:#document-fragment replacingDOMRange:range from 7 of #text > BODY > HTML > #document to 7 of #text > BODY > HTML > #document givenAction:WebViewInsertActionPasted

  • trunk/LayoutTests/platform/mac/editing/pasteboard/emacs-ctrl-k-y-001-expected.txt

    r25970 r29667  
    1111EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
    1212EDITING DELEGATE: shouldDeleteDOMRange:range from 8 of #text > DIV > DIV > BODY > HTML > #document to 0 of DIV > DIV > DIV > BODY > HTML > #document
    13 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
    14 EDITING DELEGATE: shouldChangeSelectedDOMRange:(null) toDOMRange:range from 8 of #text > DIV > DIV > BODY > HTML > #document to 8 of #text > DIV > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
    15 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
    1613EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification
    1714EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
    … …  
    2320EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
    2421EDITING DELEGATE: shouldDeleteDOMRange:range from 8 of #text > DIV > DIV > BODY > HTML > #document to 0 of DIV > DIV > DIV > BODY > HTML > #document
    25 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
    26 EDITING DELEGATE: shouldChangeSelectedDOMRange:(null) toDOMRange:range from 8 of #text > DIV > DIV > BODY > HTML > #document to 8 of #text > DIV > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
    27 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
    2822EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification
    2923EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification

  • trunk/LayoutTests/platform/mac/editing/selection/move-between-blocks-no-001-expected.txt

    r25970 r29667  
    4343EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
    4444EDITING DELEGATE: shouldDeleteDOMRange:range from 39 of #text > SPAN > DIV > BODY > HTML > #document to 40 of #text > SPAN > DIV > BODY > HTML > #document
    45 EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 39 of #text > SPAN > DIV > BODY > HTML > #document to 39 of #text > SPAN > DIV > BODY > HTML > #document toDOMRange:range from 39 of #text > SPAN > DIV > BODY > HTML > #document to 39 of #text > SPAN > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
    46 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
    4745EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification
    4846EDITING DELEGATE: shouldDeleteDOMRange:range from 38 of #text > SPAN > DIV > BODY > HTML > #document to 39 of #text > SPAN > DIV > BODY > HTML > #document

  • trunk/LayoutTests/platform/mac/editing/selection/replace-selection-1-expected.txt

    r25970 r29667  
    22EDITING DELEGATE: webViewDidBeginEditing:WebViewDidBeginEditingNotification
    33EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
    4 EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 6 of #text > DIV > BODY > HTML > #document to 0 of #text > A > DIV > BODY > HTML > #document toDOMRange:range from 4 of #text > A > DIV > BODY > HTML > #document to 4 of #text > A > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
     4EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 6 of #text > DIV > BODY > HTML > #document to 6 of #text > DIV > BODY > HTML > #document toDOMRange:range from 4 of #text > A > DIV > BODY > HTML > #document to 4 of #text > A > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
    55EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
    66EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification

  • trunk/LayoutTests/platform/mac/editing/style/remove-underline-across-paragraph-expected.txt

    r29054 r29667  
    9292EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
    9393EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
    94 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
    95 EDITING DELEGATE: shouldChangeSelectedDOMRange:(null) toDOMRange:range from 0 of #text > DIV > BODY > HTML > #document to 7 of #text > DIV > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
     94EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 0 of SPAN > DIV > BODY > HTML > #document to 7 of #text > SPAN > DIV > DIV > BODY > HTML > #document toDOMRange:range from 0 of #text > DIV > BODY > HTML > #document to 7 of #text > DIV > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
    9695EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
    9796EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification

  • trunk/LayoutTests/platform/mac/editing/style/remove-underline-across-paragraph-in-bold-expected.txt

    r29054 r29667  
    22EDITING DELEGATE: webViewDidBeginEditing:WebViewDidBeginEditingNotification
    33EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
    4 EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 0 of DIV > BODY > HTML > #document to 0 of DIV > BODY > HTML > #document toDOMRange:range from 1 of #text > B > SPAN > DIV > BODY > HTML > #document to 1 of #text > B > SPAN > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
     4EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
     5EDITING DELEGATE: shouldChangeSelectedDOMRange:(null) toDOMRange:range from 1 of #text > B > SPAN > DIV > BODY > HTML > #document to 1 of #text > B > SPAN > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
    56EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
    67EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification

  • trunk/LayoutTests/platform/mac/editing/style/remove-underline-after-paragraph-in-bold-expected.txt

    r29054 r29667  
    22EDITING DELEGATE: webViewDidBeginEditing:WebViewDidBeginEditingNotification
    33EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
    4 EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 0 of DIV > BODY > HTML > #document to 0 of DIV > BODY > HTML > #document toDOMRange:range from 1 of #text > B > SPAN > DIV > BODY > HTML > #document to 1 of #text > B > SPAN > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
     4EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
     5EDITING DELEGATE: shouldChangeSelectedDOMRange:(null) toDOMRange:range from 1 of #text > B > SPAN > DIV > BODY > HTML > #document to 1 of #text > B > SPAN > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
    56EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
    67EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification

  • trunk/LayoutTests/platform/mac/editing/style/remove-underline-expected.txt

    r25970 r29667  
    6565EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
    6666EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
    67 EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 7 of #text > SPAN > DIV > BODY > HTML > #document to 0 of SPAN > DIV > BODY > HTML > #document toDOMRange:range from 0 of #text > DIV > BODY > HTML > #document to 6 of #text > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
     67EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 7 of #text > SPAN > DIV > BODY > HTML > #document to 7 of #text > SPAN > DIV > BODY > HTML > #document toDOMRange:range from 0 of #text > DIV > BODY > HTML > #document to 6 of #text > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
    6868EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
    6969EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification

  • trunk/LayoutTests/platform/mac/editing/style/remove-underline-in-bold-expected.txt

    r25970 r29667  
    22EDITING DELEGATE: webViewDidBeginEditing:WebViewDidBeginEditingNotification
    33EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
    4 EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 0 of DIV > BODY > HTML > #document to 0 of DIV > BODY > HTML > #document toDOMRange:range from 1 of #text > B > SPAN > DIV > BODY > HTML > #document to 1 of #text > B > SPAN > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
     4EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
     5EDITING DELEGATE: shouldChangeSelectedDOMRange:(null) toDOMRange:range from 1 of #text > B > SPAN > DIV > BODY > HTML > #document to 1 of #text > B > SPAN > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
    56EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
    67EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification

  • trunk/LayoutTests/platform/mac/editing/style/unbold-in-bold-expected.txt

    r25970 r29667  
    6565EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
    6666EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
    67 EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 7 of #text > B > DIV > BODY > HTML > #document to 0 of SPAN > DIV > BODY > HTML > #document toDOMRange:range from 0 of #text > DIV > BODY > HTML > #document to 6 of #text > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
     67EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 7 of #text > B > DIV > BODY > HTML > #document to 7 of #text > B > DIV > BODY > HTML > #document toDOMRange:range from 0 of #text > DIV > BODY > HTML > #document to 6 of #text > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
    6868EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
    6969EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification

  • trunk/WebCore/ChangeLog

    r29666 r29667  
     12008-01-19  Dan Bernstein  <mitz@apple.com>
     2
     3        Reviewed by Maciej Stachowiak.
     4
     5        - fix <rdar://problem/5645813> CrashTracer: [USER] 6 crashes in Safari at com.apple.WebCore: WebCore::RenderBox::destroy + 116
     6
     7        Test: editing/selection/inconsistent-in-removeChildNode.html
     8
     9        * editing/SelectionController.cpp:
     10        (WebCore::SelectionController::nodeWillBeRemoved): If the selection
     11        base or extent are not visible any more, adjust the selection.
     12
    1132008-01-19  Oliver Hunt  <oliver@apple.com>
    214

  • trunk/WebCore/editing/SelectionController.cpp

    r29581 r29667  
    169169        return;
    170170   
    171     bool baseRemoved = removingNodeRemovesPosition(node, m_sel.base());
    172     bool extentRemoved = removingNodeRemovesPosition(node, m_sel.extent());
     171    bool baseRemoved = !m_sel.base().isCandidate() || removingNodeRemovesPosition(node, m_sel.base());
     172    bool extentRemoved = !m_sel.extent().isCandidate() || removingNodeRemovesPosition(node, m_sel.extent());
    173173    bool startRemoved = removingNodeRemovesPosition(node, m_sel.start());
    174174    bool endRemoved = removingNodeRemovesPosition(node, m_sel.end());
Note: See TracChangeset for help on using the changeset viewer.