Changeset 30095 in webkit

Timestamp:

Feb 8, 2008, 11:23:08 AM (17 years ago)

Author:

hyatt@apple.com

Message:

Fix for bug 16798, button should default to type=submit.

Reviewed by darin

• html/HTMLButtonElement.cpp: (WebCore::HTMLButtonElement::type): (WebCore::HTMLButtonElement::parseMappedAttribute):

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• html/HTMLButtonElement.cpp (modified) (2 diffs)

trunk/WebCore/ChangeLog

@@ +1 @@
+2008-02-08  David Hyatt  <hyatt@apple.com>
+
+        Fix for bug 16798, button should default to type=submit.
+
+        Reviewed by darin
+
+        * html/HTMLButtonElement.cpp:
+        (WebCore::HTMLButtonElement::type):
+        (WebCore::HTMLButtonElement::parseMappedAttribute):
+
 2008-02-08  Rodney Dawes  <dobey@wayofthemonkey.com>
 

trunk/WebCore/html/HTMLButtonElement.cpp

@@ -57 +57 @@
 const AtomicString& HTMLButtonElement::type() const
 {
-    return getAttribute(typeAttr);
+    switch (m_type) {
+        case SUBMIT: {
+            static const AtomicString submit("submit");
+            return submit;
+        }
+        case BUTTON: {
+            static const AtomicString button("button");
+            return button;
+        }
+        case RESET: {
+            static const AtomicString reset("reset");
+            return reset;
+        }
+    }
+
+    ASSERT_NOT_REACHED();
+    return emptyAtom;
 }
 
@@ -63 +79 @@
 {
     if (attr->name() == typeAttr) {
-        if (equalIgnoringCase(attr->value(), "submit"))
-            m_type = SUBMIT;
-        else if (equalIgnoringCase(attr->value(), "reset"))
+        if (equalIgnoringCase(attr->value(), "reset"))
             m_type = RESET;
         else if (equalIgnoringCase(attr->value(), "button"))
             m_type = BUTTON;
+        else
+            m_type = SUBMIT;
     } else if (attr->name() == alignAttr) {
         // Don't map 'align' attribute.  This matches what Firefox and IE do, but not Opera.