Changeset 30162 in webkit

Timestamp:

Feb 11, 2008 10:02:57 PM (16 years ago)

Author:

mitz@apple.com

Message:

WebCore:

Reviewed by Dave Hyatt.

• fix ​http://bugs.webkit.org/show_bug.cgi?id=17320 <rdar://problem/5736953> :last-child does not set the "uses sibling rules" flag

Test: fast/css/last-child-style-sharing.html

• css/CSSGrammar.y: Changed to call setUsesSiblingRules(true) for all CSS3 selectors that require it.

LayoutTests:

Reviewed by Dave Hyatt.

• test for ​http://bugs.webkit.org/show_bug.cgi?id=17320 <rdar://problem/5736953> :last-child does not set the "uses sibling rules" flag

• fast/css/last-child-style-sharing.html: Added.
• platform/mac/fast/css/last-child-style-sharing-expected.checksum: Added.
• platform/mac/fast/css/last-child-style-sharing-expected.png: Added.
• platform/mac/fast/css/last-child-style-sharing-expected.txt: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/css/last-child-style-sharing.html (added)
• LayoutTests/platform/mac/fast/css/last-child-style-sharing-expected.checksum (added)
• LayoutTests/platform/mac/fast/css/last-child-style-sharing-expected.png (added)
• LayoutTests/platform/mac/fast/css/last-child-style-sharing-expected.txt (added)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/css/CSSGrammar.y (modified) (4 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2008-02-11  Dan Bernstein  <mitz@apple.com>
+
+        Reviewed by Dave Hyatt.
+
+        - test for http://bugs.webkit.org/show_bug.cgi?id=17320
+          <rdar://problem/5736953> :last-child does not set the "uses sibling rules" flag
+
+        * fast/css/last-child-style-sharing.html: Added.
+        * platform/mac/fast/css/last-child-style-sharing-expected.checksum: Added.
+        * platform/mac/fast/css/last-child-style-sharing-expected.png: Added.
+        * platform/mac/fast/css/last-child-style-sharing-expected.txt: Added.
+
 2008-02-11  Sam Weinig  <sam@webkit.org>
 

trunk/WebCore/ChangeLog

@@ +1 @@
+2008-02-11  Dan Bernstein  <mitz@apple.com>
+
+        Reviewed by Dave Hyatt.
+
+        - fix http://bugs.webkit.org/show_bug.cgi?id=17320
+          <rdar://problem/5736953> :last-child does not set the "uses sibling rules" flag
+
+        Test: fast/css/last-child-style-sharing.html
+
+        * css/CSSGrammar.y: Changed to call setUsesSiblingRules(true) for all
+        CSS3 selectors that require it.
+
 2008-02-11  Sam Weinig  <sam@webkit.org>
 

trunk/WebCore/css/CSSGrammar.y

@@ -883 +883 @@
         else if (type == CSSSelector::PseudoEmpty ||
                  type == CSSSelector::PseudoFirstChild ||
-                 type == CSSSelector::PseudoFirstOfType) {
+                 type == CSSSelector::PseudoFirstOfType ||
+                 type == CSSSelector::PseudoLastChild ||
+                 type == CSSSelector::PseudoLastOfType ||
+                 type == CSSSelector::PseudoOnlyChild ||
+                 type == CSSSelector::PseudoOnlyOfType) {
             CSSParser* p = static_cast<CSSParser*>(parser);
             Document* doc = p->document();
@@ -918 +922 @@
         if (type == CSSSelector::PseudoUnknown)
             $$ = 0;
-        else if (type == CSSSelector::PseudoNthChild || type == CSSSelector::PseudoNthOfType) {
+        else if (type == CSSSelector::PseudoNthChild ||
+                 type == CSSSelector::PseudoNthOfType ||
+                 type == CSSSelector::PseudoNthLastChild ||
+                 type == CSSSelector::PseudoNthLastOfType) {
             if (p->document())
                 p->document()->setUsesSiblingRules(true);
@@ -933 +940 @@
         if (type == CSSSelector::PseudoUnknown)
             $$ = 0;
-        else if (type == CSSSelector::PseudoNthChild || type == CSSSelector::PseudoNthOfType) {
+        else if (type == CSSSelector::PseudoNthChild ||
+                 type == CSSSelector::PseudoNthOfType ||
+                 type == CSSSelector::PseudoNthLastChild ||
+                 type == CSSSelector::PseudoNthLastOfType) {
             if (p->document())
                 p->document()->setUsesSiblingRules(true);
@@ -949 +959 @@
         if (type == CSSSelector::PseudoUnknown)
             $$ = 0;
-        else if (type == CSSSelector::PseudoNthChild || type == CSSSelector::PseudoNthOfType) {
+        else if (type == CSSSelector::PseudoNthChild ||
+                 type == CSSSelector::PseudoNthOfType ||
+                 type == CSSSelector::PseudoNthLastChild ||
+                 type == CSSSelector::PseudoNthLastOfType) {
             if (p->document())
                 p->document()->setUsesSiblingRules(true);