Changeset 30345 in webkit

Timestamp:

Feb 17, 2008, 12:50:32 AM (17 years ago)

Author:

mitz@apple.com

Message:

WebCore:

Reviewed by Darin Adler.

• fix ​http://bugs.webkit.org/show_bug.cgi?id=17033 <rdar://problem/5709315> REGRESSION: Really long <option> causes unnecessary page scroll bars to accommodate content

Test: fast/forms/control-clip-overflow.html

• rendering/RenderFlow.cpp: (WebCore::RenderFlow::lowestPosition): Account for control clipping. (WebCore::RenderFlow::rightmostPosition): Ditto. (WebCore::RenderFlow::leftmostPosition): Ditto.

LayoutTests:

Reviewed by Darin Adler.

• test for ​http://bugs.webkit.org/show_bug.cgi?id=17033 <rdar://problem/5709315> REGRESSION: Really long <option> causes unnecessary page scroll bars to accommodate content

• fast/forms/control-clip-overflow.html: Added.
• platform/mac/fast/forms/control-clip-overflow-expected.checksum: Added.
• platform/mac/fast/forms/control-clip-overflow-expected.png: Added.
• platform/mac/fast/forms/control-clip-overflow-expected.txt: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/forms/control-clip-overflow.html (added)
• LayoutTests/platform/mac/fast/forms/control-clip-overflow-expected.checksum (added)
• LayoutTests/platform/mac/fast/forms/control-clip-overflow-expected.png (added)
• LayoutTests/platform/mac/fast/forms/control-clip-overflow-expected.txt (added)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/rendering/RenderFlow.cpp (modified) (3 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2008-02-17  Dan Bernstein  <mitz@apple.com>
+
+        Reviewed by Darin Adler.
+
+        - test for http://bugs.webkit.org/show_bug.cgi?id=17033
+          <rdar://problem/5709315> REGRESSION: Really long <option> causes unnecessary page scroll bars to accommodate content
+
+        * fast/forms/control-clip-overflow.html: Added.
+        * platform/mac/fast/forms/control-clip-overflow-expected.checksum: Added.
+        * platform/mac/fast/forms/control-clip-overflow-expected.png: Added.
+        * platform/mac/fast/forms/control-clip-overflow-expected.txt: Added.
+
 2008-02-16  Dan Bernstein  <mitz@apple.com>
 

trunk/WebCore/ChangeLog

@@ +1 @@
+2008-02-17  Dan Bernstein  <mitz@apple.com>
+
+        Reviewed by Darin Adler.
+
+        - fix http://bugs.webkit.org/show_bug.cgi?id=17033
+          <rdar://problem/5709315> REGRESSION: Really long <option> causes unnecessary page scroll bars to accommodate content
+
+        Test: fast/forms/control-clip-overflow.html
+
+        * rendering/RenderFlow.cpp:
+        (WebCore::RenderFlow::lowestPosition): Account for control clipping.
+        (WebCore::RenderFlow::rightmostPosition): Ditto.
+        (WebCore::RenderFlow::leftmostPosition): Ditto.
+
 2008-02-16  Oliver Hunt  <oliver@apple.com>
 

trunk/WebCore/rendering/RenderFlow.cpp

@@ -551 +551 @@
 {
     ASSERT(!isInlineFlow());
-    if (!includeOverflowInterior && hasOverflowClip())
+    if (!includeOverflowInterior && (hasOverflowClip() || hasControlClip()))
         return includeSelf && m_width > 0 ? overflowHeight(false) : 0;
 
@@ -575 +575 @@
 {
     ASSERT(!isInlineFlow());
-    if (!includeOverflowInterior && hasOverflowClip())
+    if (!includeOverflowInterior && (hasOverflowClip() || hasControlClip()))
         return includeSelf && m_height > 0 ? overflowWidth(false) : 0;
 
@@ -599 +599 @@
 {
     ASSERT(!isInlineFlow());
-    if (!includeOverflowInterior && hasOverflowClip())
+    if (!includeOverflowInterior && (hasOverflowClip() || hasControlClip()))
         return includeSelf && m_height > 0 ? overflowLeft(false) : m_width;