Changeset 30515 in webkit

Timestamp:

Feb 22, 2008 9:14:55 PM (16 years ago)

Author:

justin.garcia@apple.com

Message:

WebCore:

Reviewed by Anders Carlsson.

<rdar://problem/5714333> Add document.getSelection()

Add a synonym for window.getSelection() that FF supports. There were requests in
this bugs dupes to also support the IE only document.selection, but IE's Selection
object is too different than ours currently for that to be safe (specifically, we
don't support enough of IE's TextRange methods on our DOM Range object yet). I
filed <rdar://problem/5761233> to cover that.

• dom/Document.cpp: (WebCore::Document::getSelection): Added.
• dom/Document.h:
• dom/Document.idl: Ditto. JS only since this is about web compatibility.

LayoutTests:

Reviewed by Anders.

<rdar://problem/5714333> Add document.getSelection()

• editing/selection/5714333-expected.txt: Added.
• editing/selection/5714333.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/editing/selection/5714333-expected.txt (added)
• LayoutTests/editing/selection/5714333.html (added)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/dom/Document.cpp (modified) (2 diffs)
• WebCore/dom/Document.h (modified) (2 diffs)
• WebCore/dom/Document.idl (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2008-02-22  Justin Garcia  <justin.garcia@apple.com>
+
+        Reviewed by Anders.
+        
+        <rdar://problem/5714333> Add document.getSelection()
+
+        * editing/selection/5714333-expected.txt: Added.
+        * editing/selection/5714333.html: Added.
+
 2008-02-22  Oliver Hunt  <oliver@apple.com>
 

trunk/WebCore/ChangeLog

@@ +1 @@
+2008-02-22  Justin Garcia  <justin.garcia@apple.com>
+
+        Reviewed by Anders Carlsson.
+
+        <rdar://problem/5714333> Add document.getSelection()
+        
+        Add a synonym for window.getSelection() that FF supports.  There were requests in
+        this bugs dupes to also support the IE only document.selection, but IE's Selection
+        object is too different than ours currently for that to be safe (specifically, we
+        don't support enough of IE's TextRange methods on our DOM Range object yet). I
+        filed <rdar://problem/5761233> to cover that.
+
+        * dom/Document.cpp:
+        (WebCore::Document::getSelection): Added.
+        * dom/Document.h:
+        * dom/Document.idl: Ditto.  JS only since this is about web compatibility.
+
 2008-02-22  Oliver Hunt  <oliver@apple.com>
 

trunk/WebCore/dom/Document.cpp

@@ -42 +42 @@
 #include "DocumentLoader.h"
 #include "DocumentType.h"
+#include "DOMWindow.h"
 #include "EditingText.h"
 #include "Editor.h"
@@ -3768 +3769 @@
 }
 
+// FF method for accessing the selection added for compatability.
+DOMSelection* Document::getSelection() const
+{
+    return frame() ? frame()->domWindow()->getSelection() : 0;
+}
+
 #if ENABLE(DATABASE)
 

trunk/WebCore/dom/Document.h

@@ -61 +61 @@
     class Database;
     class DOMImplementation;
+    class DOMSelection;
     class DOMWindow;
     class DatabaseThread;
@@ -691 +692 @@
     void cancelFocusAppearanceUpdate();
     
+    // FF method for accessing the selection added for compatability.
+    DOMSelection* getSelection() const;
+    
 private:
     CSSStyleSelector* m_styleSelector;

trunk/WebCore/dom/Document.idl

@@ -194 +194 @@
 
         // Mozilla extensions
-
+#if defined(LANGUAGE_JAVASCRIPT)
+        DOMSelection       getSelection();
+#endif
         readonly attribute [ConvertNullStringTo=Null] DOMString characterSet;