Changeset 30547 in webkit

Timestamp:

Feb 23, 2008, 11:55:40 PM (17 years ago)

Author:

Darin Adler

Message:

Reviewed by Sam.

• fix ​http://bugs.webkit.org/show_bug.cgi?id=17508 REGRESSION (r30535): mailto regression tests failing

• html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::submit): Restore the old logic, with its unpleasant trip through String do to the replace operation. It's inefficient, but there's no real reason to worry about the efficiency of mailto forms, since that feature is nearly obsolete.

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• html/HTMLFormElement.cpp (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2008-02-23  Darin Adler  <darin@apple.com>
+
+        Reviewed by Sam.
+
+        - fix http://bugs.webkit.org/show_bug.cgi?id=17508
+          REGRESSION (r30535): mailto regression tests failing
+
+        * html/HTMLFormElement.cpp:
+        (WebCore::HTMLFormElement::submit): Restore the old logic, with its unpleasant
+        trip through String do to the replace operation. It's inefficient, but there's
+        no real reason to worry about the efficiency of mailto forms, since that feature
+        is nearly obsolete.
+
 2008-02-23  Darin Adler  <darin@apple.com>
 

trunk/WebCore/html/HTMLFormElement.cpp

@@ -488 +488 @@
                 Vector<char> bodyData;
                 appendString(bodyData, "body=");
-                appendEncodedString(bodyData, body.replace('+', ' ').utf8());
-                data = FormData::create(bodyData);
+                appendEncodedString(bodyData, body.utf8());
+                data = FormData::create(String(bodyData.data(), bodyData.size()).replace('+', "%20").latin1());
             }
             frame->loader()->submitForm("POST", m_url, data, m_target, enctype(), String(), event);