Changeset 30592 in webkit


Ignore:
Timestamp:
Feb 26, 2008 2:15:02 AM (16 years ago)
Author:
ap@webkit.org
Message:

Reviewed by Darin. Tweaked and landed by Alexey.

​http://bugs.webkit.org/show_bug.cgi?id=17411
Ideographic comma and full stop should be treated as line-breakable characters

Test: fast/text/line-breaks-after-ideographic-comma-or-full-stop.html

  • platform/text/CharacterNames.h: Added ideographicComma and ideographicFullStop.
  • rendering/break_lines.cpp: (WebCore::shouldBreakAfter): Added a workaround for an issue in Unicode 5.0 that is causing this.
Location:
trunk
Files:
2 added
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r30590 r30592  
     12008-02-26  Satoshi Nakagawa  <artension@gmail.com>
     2
     3        Reviewed by Darin. Tweaked and landed by Alexey.
     4
     5        - test for http://bugs.webkit.org/show_bug.cgi?id=17411
     6
     7        * fast/text/line-breaks-after-ideographic-comma-or-full-stop.html: Added.
     8        * fast/text/line-breaks-after-ideographic-comma-or-full-stop-expected.txt: Added
     9
    1102008-02-25  Dan Bernstein  <mitz@apple.com>
    211

  • trunk/WebCore/ChangeLog

    r30591 r30592  
     12008-02-26  Satoshi Nakagawa  <artension@gmail.com>
     2
     3        Reviewed by Darin. Tweaked and landed by Alexey.
     4
     5        http://bugs.webkit.org/show_bug.cgi?id=17411
     6        Ideographic comma and full stop should be treated as line-breakable characters
     7
     8        Test: fast/text/line-breaks-after-ideographic-comma-or-full-stop.html
     9
     10        * platform/text/CharacterNames.h: Added ideographicComma and ideographicFullStop.
     11        * rendering/break_lines.cpp: (WebCore::shouldBreakAfter): Added a workaround for an issue in
     12        Unicode 5.0 that is causing this.
     13
    1142008-02-26  MorganL  <morganl.webkit@yahoo.com>
    215

  • trunk/WebCore/platform/text/CharacterNames.h

    r29905 r30592  
    4040    const UChar horizontalEllipsis = 0x2026;
    4141    const UChar ideographicSpace = 0x3000;
     42    const UChar ideographicComma = 0x3001;
     43    const UChar ideographicFullStop = 0x3002;
    4244    const UChar leftToRightMark = 0x200E;
    4345    const UChar leftToRightEmbed = 0x202A;

  • trunk/WebCore/rendering/break_lines.cpp

    r29915 r30592  
    4848{
    4949    // Match WinIE's breaking strategy, which is to always allow breaks after hyphens and question marks.
     50    // FIXME: it appears that IE behavior is more complex, see <http://bugs.webkit.org/show_bug.cgi?id=17475>.
    5051    switch (ch) {
    5152        case '-':
    5253        case '?':
    5354        case softHyphen:
     55        // FIXME: cases for ideographicComma and ideographicFullStop are a workaround for an issue in Unicode 5.0
     56        // which is likely to be resolved in Unicode 5.1 <http://bugs.webkit.org/show_bug.cgi?id=17411>.
     57        // We may want to remove or conditionalize this workaround at some point.
     58        case ideographicComma:
     59        case ideographicFullStop:
    5460            return true;
    5561        default:
Note: See TracChangeset for help on using the changeset viewer.