Changeset 30595 in webkit

Timestamp:

Feb 26, 2008, 11:01:53 AM (17 years ago)

Author:

mitz@apple.com

Message:

WebCore:

Reviewed by Darin Adler.

• fix ​http://bugs.webkit.org/show_bug.cgi?id=17555 <rdar://problem/5766016> REGRESSION (r27351): Thumbnails positioned wrong on Getty Images results page

Test: fast/dynamic/subtree-table-cell-height.html

• rendering/RenderObject.cpp: (WebCore::objectIsRelayoutBoundary): Exclude table cells, since their height depends on their contents even if the CSS height property is fixed.

LayoutTests:

Reviewed by Darin Adler.

• test for ​http://bugs.webkit.org/show_bug.cgi?id=17555 <rdar://problem/5766016> REGRESSION (r27351): Thumbnails positioned wrong on Getty Images results page

• fast/dynamic/subtree-table-cell-height.html: Added.
• platform/mac/fast/dynamic/subtree-table-cell-height-expected.checksum: Added.
• platform/mac/fast/dynamic/subtree-table-cell-height-expected.png: Added.
• platform/mac/fast/dynamic/subtree-table-cell-height-expected.txt: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/dynamic/subtree-table-cell-height.html (added)
• LayoutTests/platform/mac/fast/dynamic/subtree-table-cell-height-expected.checksum (added)
• LayoutTests/platform/mac/fast/dynamic/subtree-table-cell-height-expected.png (added)
• LayoutTests/platform/mac/fast/dynamic/subtree-table-cell-height-expected.txt (added)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/rendering/RenderObject.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2008-02-26  Dan Bernstein  <mitz@apple.com>
+
+        Reviewed by Darin Adler.
+
+        - test for http://bugs.webkit.org/show_bug.cgi?id=17555
+          <rdar://problem/5766016> REGRESSION (r27351): Thumbnails positioned wrong on Getty Images results page
+
+        * fast/dynamic/subtree-table-cell-height.html: Added.
+        * platform/mac/fast/dynamic/subtree-table-cell-height-expected.checksum: Added.
+        * platform/mac/fast/dynamic/subtree-table-cell-height-expected.png: Added.
+        * platform/mac/fast/dynamic/subtree-table-cell-height-expected.txt: Added.
+
 2008-02-26  Satoshi Nakagawa  <artension@gmail.com>
 

trunk/WebCore/ChangeLog

@@ +1 @@
+2008-02-26  Dan Bernstein  <mitz@apple.com>
+
+        Reviewed by Darin Adler.
+
+        - fix http://bugs.webkit.org/show_bug.cgi?id=17555
+          <rdar://problem/5766016> REGRESSION (r27351): Thumbnails positioned wrong on Getty Images results page
+
+        Test: fast/dynamic/subtree-table-cell-height.html
+
+        * rendering/RenderObject.cpp:
+        (WebCore::objectIsRelayoutBoundary): Exclude table cells, since their
+        height depends on their contents even if the CSS height property is
+        fixed.
+
 2008-02-25  Sam Weinig  <sam@webkit.org>
 

trunk/WebCore/rendering/RenderObject.cpp

@@ -711 +711 @@
 static inline bool objectIsRelayoutBoundary(const RenderObject *obj) 
 {
-    // FIXME: In future it may be possible to broaden this condition in order to improve performance 
+    // FIXME: In future it may be possible to broaden this condition in order to improve performance.
+    // Table cells are excluded because even when their CSS height is fixed, their height()
+    // may depend on their contents.
     return obj->isTextField() || obj->isTextArea()
-        || obj->hasOverflowClip() && !obj->style()->width().isIntrinsicOrAuto() && !obj->style()->height().isIntrinsicOrAuto() && !obj->style()->height().isPercent()
+        || obj->hasOverflowClip() && !obj->style()->width().isIntrinsicOrAuto() && !obj->style()->height().isIntrinsicOrAuto() && !obj->style()->height().isPercent() && !obj->isTableCell()
 #if ENABLE(SVG)
            || obj->isSVGRoot()