Changeset 30624 in webkit

Timestamp:

Feb 27, 2008, 8:50:19 AM (17 years ago)

Author:

ap@webkit.org

Message:

2008-02-27 Sriram Neelakandan <​sriram.neelakandan@gmail.com>

Reviewed, tweaked and landed by ap.

​http://bugs.webkit.org/show_bug.cgi?id=17487
HTMLInput mysteriously fails to work if ICU dat file is missing

• platform/text/TextBreakIteratorICU.cpp: (WebCore::setUpIterator): Assert that the iterator has been opened.

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/text/TextBreakIteratorICU.cpp (modified) (2 diffs)

trunk/WebCore/ChangeLog

@@ +1 @@
+2008-02-27  Sriram Neelakandan  <sriram.neelakandan@gmail.com>
+
+        Reviewed, tweaked and landed by ap.
+
+        http://bugs.webkit.org/show_bug.cgi?id=17487
+        HTMLInput mysteriously fails to work if ICU dat file is missing
+
+        * platform/text/TextBreakIteratorICU.cpp: (WebCore::setUpIterator): Assert that the iterator
+        has been opened.
+
 2008-02-27  Adam Roben  <aroben@apple.com>
 

trunk/WebCore/platform/text/TextBreakIteratorICU.cpp

@@ -26 +26 @@
 
 #include <unicode/ubrk.h>
+#include <wtf/Assertions.h>
 
 namespace WebCore {
@@ -39 +40 @@
         iterator = static_cast<TextBreakIterator*>(ubrk_open(type, currentTextBreakLocaleID(), 0, 0, &openStatus));
         createdIterator = true;
+        ASSERT_WITH_MESSAGE(U_SUCCESS(openStatus), "ICU could not open a break iterator: %s (%d)", u_errorName(openStatus), openStatus);
     }
     if (!iterator)