Changeset 30644 in webkit


Ignore:
Timestamp:
Feb 27, 2008 9:38:52 PM (16 years ago)
Author:
mitz@apple.com
Message:

WebCore:

Reviewed by John Sullivan.

  • fix <rdar://problem/5607547> Single letter surrounded by soft hyphens can disappear

Test: fast/text/soft-hyphen-2.html

  • rendering/bidi.cpp: (WebCore::chopMidpointsAt): Changed to iterate midpoints backwards, so that if there are two midpoints at the given position, only the last one will be chopped off.

LayoutTests:

Reviewed by John Sullivan.

  • test for <rdar://problem/5607547> Single letter surrounded by soft hyphens can disappear
  • fast/text/soft-hyphen-2.html: Added.
  • platform/mac/fast/text/soft-hyphen-2-expected.checksum: Added.
  • platform/mac/fast/text/soft-hyphen-2-expected.png: Added.
  • platform/mac/fast/text/soft-hyphen-2-expected.txt: Added.
Location:
trunk
Files:
4 added
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r30643 r30644  
     12008-02-27  Dan Bernstein  <mitz@apple.com>
     2
     3        Reviewed by John Sullivan.
     4
     5        - test for <rdar://problem/5607547> Single letter surrounded by soft hyphens can disappear
     6
     7        * fast/text/soft-hyphen-2.html: Added.
     8        * platform/mac/fast/text/soft-hyphen-2-expected.checksum: Added.
     9        * platform/mac/fast/text/soft-hyphen-2-expected.png: Added.
     10        * platform/mac/fast/text/soft-hyphen-2-expected.txt: Added.
     11
    1122008-02-27  Brady Eidson  <beidson@apple.com>
    213

  • trunk/WebCore/ChangeLog

    r30642 r30644  
     12008-02-27  Dan Bernstein  <mitz@apple.com>
     2
     3        Reviewed by John Sullivan.
     4
     5        - fix <rdar://problem/5607547> Single letter surrounded by soft hyphens can disappear
     6
     7        Test: fast/text/soft-hyphen-2.html
     8
     9        * rendering/bidi.cpp:
     10        (WebCore::chopMidpointsAt): Changed to iterate midpoints backwards, so
     11        that if there are two midpoints at the given position, only the last one
     12        will be chopped off.
     13
    1142008-02-27  Dan Bernstein  <mitz@apple.com>
    215

  • trunk/WebCore/rendering/bidi.cpp

    r30642 r30644  
    326326        return;
    327327    BidiIterator* midpoints = smidpoints->data();
    328     for (unsigned i = 0; i < sNumMidpoints; i++) {
     328    for (int i = sNumMidpoints - 1; i >= 0; i--) {
    329329        const BidiIterator& point = midpoints[i];
    330330        if (point.obj == obj && point.pos == pos) {
Note: See TracChangeset for help on using the changeset viewer.