Changeset 30952 in webkit

Timestamp:

Mar 10, 2008, 9:42:14 PM (17 years ago)

Author:

justin.garcia@apple.com

Message:

WebCore:

Reviewed by Sam.

<rdar://problem/5779984> REGRESSION (r30391): GMail: Safari won't display the Edit Link dialog

• bindings/js/JSCSSStyleDeclarationCustom.cpp: (WebCore::hasCSSPropertyNamePrefix): Fixed a typo. The code was only comparing the first character of the prefix to the first character of the property name.

LayoutTests:

Reviewed by Sam.

<rdar://problem/5779984> REGRESSION (r30391): GMail: Safari won't display the Edit Link dialog

• editing/pasteboard/5780697-2-expected.txt: Added.
• editing/pasteboard/5780697-2.html: Added.
• editing/selection/5779984-1-expected.txt: Added.
• editing/selection/5779984-1.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/editing/selection/5779984-1-expected.txt (added)
• LayoutTests/editing/selection/5779984-1.html (added)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/bindings/js/JSCSSStyleDeclarationCustom.cpp (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2008-03-10  Justin Garcia  <justin.garcia@apple.com>
+
+        Reviewed by Sam.
+        
+        <rdar://problem/5779984> REGRESSION (r30391): GMail: Safari won't display the Edit Link dialog
+
+        * editing/pasteboard/5780697-2-expected.txt: Added.
+        * editing/pasteboard/5780697-2.html: Added.
+        * editing/selection/5779984-1-expected.txt: Added.
+        * editing/selection/5779984-1.html: Added.
+
 2008-03-10  Sam Weinig  <sam@webkit.org>
 

trunk/WebCore/ChangeLog

@@ +1 @@
+2008-03-10  Justin Garcia  <justin.garcia@apple.com>
+
+        Reviewed by Sam.
+
+        <rdar://problem/5779984> REGRESSION (r30391): GMail: Safari won't display the Edit Link dialog
+
+        * bindings/js/JSCSSStyleDeclarationCustom.cpp:
+        (WebCore::hasCSSPropertyNamePrefix): Fixed a typo.  The code was only
+        comparing the first character of the prefix to the first character
+        of the property name.
+
 2008-03-10  Andre Boule  <aboule@apple.com>
 

trunk/WebCore/bindings/js/JSCSSStyleDeclarationCustom.cpp

@@ -42 +42 @@
 // Check for a CSS prefix.
 // Passed prefix is all lowercase.
-// First characters of property name may be upper or lowercase.
+// First character of property name may be upper or lowercase.
 // Other characters in the prefix within the property name must be lowercase.
 // The prefix within the property name must be followed by a capital letter.
@@ -62 +62 @@
         if (!prefix[i])
             return isASCIIUpper(propertyName.data()[i]);
-        if (propertyName.data()[0] != prefix[0])
+        if (propertyName.data()[i] != prefix[i])
             return false;
     }