Changeset 31139 in webkit

Timestamp:

Mar 18, 2008, 3:30:00 PM (17 years ago)

Author:

eric@webkit.org

Message:

Reviewed by Oliver.

Fix SVGImage crash seen once, and obvious via code inspection.

I was not able to find a test case for this.

• svg/graphics/SVGImage.cpp: (WebCore::SVGImage::setContainerSize): (WebCore::SVGImage::usesContainerSize): (WebCore::SVGImage::hasRelativeWidth): (WebCore::SVGImage::hasRelativeHeight):

File:

• trunk/WebCore/svg/graphics/SVGImage.cpp (modified) (4 diffs)

trunk/WebCore/svg/graphics/SVGImage.cpp

@@ -71 +71 @@
         return;
 
+    if (!m_frame || !m_frame->document())
+        return;
     SVGSVGElement* rootElement = static_cast<SVGDocument*>(m_frame->document())->rootElement();
     if (!rootElement)
@@ -80 +82 @@
 bool SVGImage::usesContainerSize() const
 {
+    if (!m_frame || !m_frame->document())
+        return false;
     SVGSVGElement* rootElement = static_cast<SVGDocument*>(m_frame->document())->rootElement();
     if (!rootElement)
@@ -115 +119 @@
 bool SVGImage::hasRelativeWidth() const
 {
+    if (!m_frame || !m_frame->document())
+        return false;
     SVGSVGElement* rootElement = static_cast<SVGDocument*>(m_frame->document())->rootElement();
     if (!rootElement)
@@ -124 +130 @@
 bool SVGImage::hasRelativeHeight() const
 {
+    if (!m_frame || !m_frame->document())
+        return false;
     SVGSVGElement* rootElement = static_cast<SVGDocument*>(m_frame->document())->rootElement();
     if (!rootElement)