Changeset 31313 in webkit


Ignore:
Timestamp:
Mar 26, 2008, 7:33:07 AM (17 years ago)
Author:
mitz@apple.com
Message:

WebCore:

Reviewed by Darin Adler.

Tests: fast/repaint/subtree-root-clip.html

fast/repaint/subtree-root-clip-2.html
fast/repaint/subtree-root-clip-3.html

  • rendering/LayoutState.cpp: (WebCore::LayoutState::LayoutState): Changed to not set an initial clip. Since the root is clipping, there is no need to set a clip, and setting the clip based on the container was wrong because often the root was not included in the container's overflow rect because it had its own layer.
  • rendering/RenderBox.cpp: (WebCore::RenderBox::absolutePosition): Removed code that added table cell's extra top offset only in the slow (recursive) code path.
  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::absolutePosition): Added code to add the extra top offset in both code paths.

LayoutTests:

Reviewed by Darin Adler.

  • fast/repaint/subtree-root-clip-2.html: Added.
  • fast/repaint/subtree-root-clip-3.html: Added.
  • fast/repaint/subtree-root-clip.html: Added.
  • platform/mac/fast/repaint/subtree-root-clip-2-expected.checksum: Added.
  • platform/mac/fast/repaint/subtree-root-clip-2-expected.png: Added.
  • platform/mac/fast/repaint/subtree-root-clip-2-expected.txt: Added.
  • platform/mac/fast/repaint/subtree-root-clip-3-expected.checksum: Added.
  • platform/mac/fast/repaint/subtree-root-clip-3-expected.png: Added.
  • platform/mac/fast/repaint/subtree-root-clip-3-expected.txt: Added.
  • platform/mac/fast/repaint/subtree-root-clip-expected.checksum: Added.
  • platform/mac/fast/repaint/subtree-root-clip-expected.png: Added.
  • platform/mac/fast/repaint/subtree-root-clip-expected.txt: Added.
Location:
trunk
Files:
12 added
5 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r31311 r31313  
     12008-03-26  Dan Bernstein  <mitz@apple.com>
     2
     3        Reviewed by Darin Adler.
     4
     5        - tests for http://bugs.webkit.org/show_bug.cgi?id=17994
     6          REGRESSION (523-525+) View not updated when changing CSS size via JavaScript
     7        - and http://bugs.webkit.org/show_bug.cgi?id=18063
     8          REGRESSION (r31250): Small bug that just cropped up in WebKit r31275
     9
     10        * fast/repaint/subtree-root-clip-2.html: Added.
     11        * fast/repaint/subtree-root-clip-3.html: Added.
     12        * fast/repaint/subtree-root-clip.html: Added.
     13        * platform/mac/fast/repaint/subtree-root-clip-2-expected.checksum: Added.
     14        * platform/mac/fast/repaint/subtree-root-clip-2-expected.png: Added.
     15        * platform/mac/fast/repaint/subtree-root-clip-2-expected.txt: Added.
     16        * platform/mac/fast/repaint/subtree-root-clip-3-expected.checksum: Added.
     17        * platform/mac/fast/repaint/subtree-root-clip-3-expected.png: Added.
     18        * platform/mac/fast/repaint/subtree-root-clip-3-expected.txt: Added.
     19        * platform/mac/fast/repaint/subtree-root-clip-expected.checksum: Added.
     20        * platform/mac/fast/repaint/subtree-root-clip-expected.png: Added.
     21        * platform/mac/fast/repaint/subtree-root-clip-expected.txt: Added.
     22
    1232008-03-24  Maciej Stachowiak  <mjs@apple.com>
    224

  • trunk/WebCore/ChangeLog

    r31312 r31313  
     12008-03-26  Dan Bernstein  <mitz@apple.com>
     2
     3        Reviewed by Darin Adler.
     4
     5        - fix http://bugs.webkit.org/show_bug.cgi?id=17994
     6          REGRESSION (523-525+) View not updated when changing CSS size via JavaScript
     7        - fix http://bugs.webkit.org/show_bug.cgi?id=18063
     8          REGRESSION (r31250): Small bug that just cropped up in WebKit r31275
     9
     10        Tests: fast/repaint/subtree-root-clip.html
     11               fast/repaint/subtree-root-clip-2.html
     12               fast/repaint/subtree-root-clip-3.html
     13
     14        * rendering/LayoutState.cpp:
     15        (WebCore::LayoutState::LayoutState): Changed to not set an initial clip.
     16        Since the root is clipping, there is no need to set a clip, and setting
     17        the clip based on the container was wrong because often the root was
     18        not included in the container's overflow rect because it had its own
     19        layer.
     20        * rendering/RenderBox.cpp:
     21        (WebCore::RenderBox::absolutePosition): Removed code that added table
     22        cell's extra top offset only in the slow (recursive) code path.
     23        * rendering/RenderTableCell.cpp:
     24        (WebCore::RenderTableCell::absolutePosition): Added code to add the
     25        extra top offset in both code paths.
     26
    1272008-03-26  Simon Hausmann  <hausmann@webkit.org>
    228

  • trunk/WebCore/rendering/LayoutState.cpp

    r29663 r31313  
    8282
    8383LayoutState::LayoutState(RenderObject* root)
     84    : m_clipped(false)
    8485{
    8586    RenderObject* container = root->container();
    86     m_clipped = true;
    87     m_clipRect = container->absoluteClippedOverflowRect();
    8887    int x = 0;
    8988    int y = 0;

  • trunk/WebCore/rendering/RenderBox.cpp

    r31257 r31313  
    885885    RenderObject* o = container();
    886886    if (o && o->absolutePosition(xPos, yPos, fixed)) {
    887         yPos += o->borderTopExtra();
    888 
    889887        if (style()->position() == AbsolutePosition) {
    890888            IntSize offset = offsetForPositionedInContainer(o);

  • trunk/WebCore/rendering/RenderTableCell.cpp

    r31200 r31313  
    200200{
    201201    bool result = RenderBlock::absolutePosition(xPos, yPos, fixed);
     202    yPos += m_topExtra;
    202203    RenderView* v = view();
    203204    if (!v || !v->layoutState()) {
Note: See TracChangeset for help on using the changeset viewer.