Changeset 39514 in webkit


Ignore:
Timestamp:
Dec 29, 2008 11:46:02 PM (15 years ago)
Author:
ap@webkit.org
Message:

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=23023
Remove incomplete support for opportunistic appcache entries

No change in behavior, thus no test.

  • loader/appcache/ApplicationCacheResource.h: (WebCore::ApplicationCacheResource::Type): Removed Opportunistic bit, will re-use when schema version changes.
  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::scheduleApplicationCacheLoad):
  • loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::didFinishLoadingManifest):
  • loader/appcache/ApplicationCacheResource.cpp: (WebCore::ApplicationCacheResource::dumpType):
Location:
trunk/WebCore
Files:
5 edited

Legend:

Unmodified
Added
Removed
  • trunk/WebCore/ChangeLog

    r39511 r39514  
     12008-12-29  Alexey Proskuryakov  <ap@webkit.org>
     2
     3        Reviewed by Sam Weinig.
     4
     5        https://bugs.webkit.org/show_bug.cgi?id=23023
     6        Remove incomplete support for opportunistic appcache entries
     7
     8        No change in behavior, thus no test.
     9
     10        * loader/appcache/ApplicationCacheResource.h:
     11        (WebCore::ApplicationCacheResource::Type): Removed Opportunistic bit, will re-use when schema
     12        version changes.
     13
     14        * loader/DocumentLoader.cpp:
     15        (WebCore::DocumentLoader::scheduleApplicationCacheLoad):
     16        * loader/appcache/ApplicationCacheGroup.cpp:
     17        (WebCore::ApplicationCacheGroup::didFinishLoadingManifest):
     18        * loader/appcache/ApplicationCacheResource.cpp:
     19        (WebCore::ApplicationCacheResource::dumpType):
     20
    1212008-12-29  Dirk Schulze  <krit@webkit.org>
    222
  • trunk/WebCore/loader/DocumentLoader.cpp

    r39474 r39514  
    894894    ApplicationCacheResource* resource;
    895895    if (!shouldLoadResourceFromApplicationCache(request, resource))
    896         // FIXME: Handle opportunistic caching namespaces
    897896        return false;
    898897   
  • trunk/WebCore/loader/appcache/ApplicationCacheGroup.cpp

    r39478 r39514  
    469469    }
    470470       
    471     // FIXME: Add the opportunistic caching namespaces and their fallbacks.
    472    
    473471    // We have the manifest, now download the resources.
    474472    m_status = Downloading;
     
    493491        for (ApplicationCache::ResourceMap::const_iterator it = m_newestCache->begin(); it != end; ++it) {
    494492            unsigned type = it->second->type();
    495             if (type & (ApplicationCacheResource::Opportunistic | ApplicationCacheResource::Implicit | ApplicationCacheResource::Dynamic))
     493            if (type & (ApplicationCacheResource::Implicit | ApplicationCacheResource::Dynamic))
    496494                addEntry(it->first, type);
    497495        }
  • trunk/WebCore/loader/appcache/ApplicationCacheResource.cpp

    r33441 r39514  
    5858    if (type & Fallback)
    5959        printf("fallback ");
    60     if (type & Opportunistic)
    61         printf("opportunistic ");
    6260    if (type & Dynamic)
    6361        printf("dynamic ");
  • trunk/WebCore/loader/appcache/ApplicationCacheResource.h

    r33051 r39514  
    4141        Foreign = 1 << 3,
    4242        Fallback = 1 << 4,
    43         Opportunistic = 1 << 5,
     43        // Bit 5 was used for opportunistic entries, which were removed from the spec.
    4444        Dynamic = 1 << 6
    4545    };
Note: See TracChangeset for help on using the changeset viewer.