Changeset 43451 in webkit


Ignore:
Timestamp:
May 9, 2009 10:04:30 PM (15 years ago)
Author:
mitz@apple.com
Message:

WebCore:

Reviewed by Geoffrey Garen and Mark Rowe.

Test: fast/dom/HTMLFormElement/adopt-assertion.html

  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::willMoveToNewOwnerDocument): Overrides of this method are required to call the base class implementation. Do it. (WebCore::HTMLFormElement::didMoveToNewOwnerDocument): Ditto.

LayoutTests:

Reviewed by Geoffrey Garen and Mark Rowe.

  • fast/dom/HTMLFormElement/adopt-assertion-expected.txt: Added.
  • fast/dom/HTMLFormElement/adopt-assertion.html: Added.
Location:
trunk
Files:
2 added
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r43446 r43451  
     12009-05-09  Dan Bernstein  <mitz@apple.com>
     2
     3        Reviewed by Geoffrey Garen and Mark Rowe.
     4
     5        - test for https://bugs.webkit.org/show_bug.cgi?id=25666
     6          Assertion failure in Node::setDocument()
     7          (willMoveToNewOwnerDocumentWasCalled) when adopting a <form> element
     8
     9        * fast/dom/HTMLFormElement/adopt-assertion-expected.txt: Added.
     10        * fast/dom/HTMLFormElement/adopt-assertion.html: Added.
     11
    1122009-05-09  Geoffrey Garen  <ggaren@apple.com>
    213

  • trunk/WebCore/ChangeLog

    r43442 r43451  
     12009-05-09  Dan Bernstein  <mitz@apple.com>
     2
     3        Reviewed by Geoffrey Garen and Mark Rowe.
     4
     5        - fix https://bugs.webkit.org/show_bug.cgi?id=25666
     6          Assertion failure in Node::setDocument()
     7          (willMoveToNewOwnerDocumentWasCalled) when adopting a <form> element
     8
     9        Test: fast/dom/HTMLFormElement/adopt-assertion.html
     10
     11        * html/HTMLFormElement.cpp:
     12        (WebCore::HTMLFormElement::willMoveToNewOwnerDocument): Overrides of
     13        this method are required to call the base class implementation. Do it.
     14        (WebCore::HTMLFormElement::didMoveToNewOwnerDocument): Ditto.
     15
    1162009-03-29  Kevin Ollivier  <kevino@theolliviers.com>
    217

  • trunk/WebCore/html/HTMLFormElement.cpp

    r43187 r43451  
    629629    if (!m_autocomplete)
    630630        document()->unregisterForDocumentActivationCallbacks(this);
     631    HTMLElement::willMoveToNewOwnerDocument();
    631632}
    632633
    … …  
    635636    if(m_autocomplete)
    636637        document()->registerForDocumentActivationCallbacks(this);
     638    HTMLElement::didMoveToNewOwnerDocument();
    637639}
    638640
Note: See TracChangeset for help on using the changeset viewer.