Changeset 43458 in webkit

Timestamp:

May 10, 2009 9:26:10 AM (15 years ago)

Author:

mitz@apple.com

Message:

WebCore:

Reviewed by Dave Kilzer.

• fix ​https://bugs.webkit.org/show_bug.cgi?id=25602 REGRESSION: fast/overflow/overflow-focus-ring.html seems double-drawn on ToT

Test: fast/layers/self-painting-outline.html

• rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintLayer): Paint the layer's own outline only if it is a self-painting layer.

LayoutTests:

Reviewed by Dave Kilzer.

• new test and correct results for ​https://bugs.webkit.org/show_bug.cgi?id=25602 REGRESSION: fast/overflow/overflow-focus-ring.html seems double-drawn on ToT

• fast/layers/self-painting-outline.html: Added.
• platform/mac/fast/overflow/overflow-focus-ring-expected.checksum: Updated.
• platform/mac/fast/overflow/overflow-focus-ring-expected.png: Updated.
• platform/mac/fast/layers/self-painting-outline-expected.checksum: Added.
• platform/mac/fast/layers/self-painting-outline-expected.png: Added.
• platform/mac/fast/layers/self-painting-outline-expected.txt: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/layers/self-painting-outline.html (added)
• LayoutTests/platform/mac/fast/layers/self-painting-outline-expected.checksum (added)
• LayoutTests/platform/mac/fast/layers/self-painting-outline-expected.png (added)
• LayoutTests/platform/mac/fast/layers/self-painting-outline-expected.txt (added)
• LayoutTests/platform/mac/fast/overflow/overflow-focus-ring-expected.checksum (modified) (1 diff)
• LayoutTests/platform/mac/fast/overflow/overflow-focus-ring-expected.png (modified) (previous)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/rendering/RenderLayer.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2009-05-10  Dan Bernstein  <mitz@apple.com>
+
+        Reviewed by Dave Kilzer.
+
+        - new test and correct results for https://bugs.webkit.org/show_bug.cgi?id=25602
+          REGRESSION: fast/overflow/overflow-focus-ring.html seems double-drawn
+          on ToT
+
+        * fast/layers/self-painting-outline.html: Added.
+        * platform/mac/fast/overflow/overflow-focus-ring-expected.checksum: Updated.
+        * platform/mac/fast/overflow/overflow-focus-ring-expected.png: Updated.
+        * platform/mac/fast/layers/self-painting-outline-expected.checksum: Added.
+        * platform/mac/fast/layers/self-painting-outline-expected.png: Added.
+        * platform/mac/fast/layers/self-painting-outline-expected.txt: Added.
+
 2009-05-09  Dan Bernstein  <mitz@apple.com>
 

trunk/LayoutTests/platform/mac/fast/overflow/overflow-focus-ring-expected.checksum

@@ -1 @@
-3c232b4f332556ee3dd41efdac1d8425
+3e94a655f09a4899cbd3f4ecee6275d1

trunk/WebCore/ChangeLog

@@ +1 @@
+2009-05-10  Dan Bernstein  <mitz@apple.com>
+
+        Reviewed by Dave Kilzer.
+
+        - fix https://bugs.webkit.org/show_bug.cgi?id=25602
+          REGRESSION: fast/overflow/overflow-focus-ring.html seems double-drawn
+          on ToT
+
+        Test: fast/layers/self-painting-outline.html
+
+        * rendering/RenderLayer.cpp:
+        (WebCore::RenderLayer::paintLayer): Paint the layer's own outline only
+        if it is a self-painting layer.
+
 2009-05-09  Dan Bernstein  <mitz@apple.com>
 

trunk/WebCore/rendering/RenderLayer.cpp

@@ -2085 +2085 @@
     }
     
-    if (!outlineRect.isEmpty()) {
+    if (!outlineRect.isEmpty() && isSelfPaintingLayer()) {
         // Paint our own outline
         RenderObject::PaintInfo paintInfo(p, outlineRect, PaintPhaseSelfOutline, false, paintingRootForRenderer, 0);