Changeset 43876 in webkit

Timestamp:

May 19, 2009 2:57:01 PM (15 years ago)

Author:

Antti Koivisto

Message:

WebCore:

2009-05-19 Antti Koivisto <Antti Koivisto>

Reviewed by Darin Adler).

<rdar://problem/6902674> REGRESSION: Query parameters are sometimes incorrect in URL (23135)

Push characters back in correct order when entity parsing fails after 3 characters.

Test: fast/tokenizer/preload-scanner-entities.html

• html/PreloadScanner.cpp: (WebCore::PreloadScanner::consumeEntity):

LayoutTests:

2009-05-19 Antti Koivisto <Antti Koivisto>

Reviewed by Darin Adler.

<rdar://problem/6902674> REGRESSION: Query parameters are sometimes incorrect in URL (23135)

• fast/tokenizer/preload-scanner-entities-expected.txt: Added.
• fast/tokenizer/preload-scanner-entities.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/tokenizer/preload-scanner-entities-expected.txt (added)
• LayoutTests/fast/tokenizer/preload-scanner-entities.html (added)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/html/PreloadScanner.cpp (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2009-05-19  Antti Koivisto  <antti@apple.com>
+
+        Reviewed by Darin Adler.
+        
+        <rdar://problem/6902674> REGRESSION: Query parameters are sometimes incorrect in URL (23135)
+
+        * fast/tokenizer/preload-scanner-entities-expected.txt: Added.
+        * fast/tokenizer/preload-scanner-entities.html: Added.
+
 2009-05-19  Yichao Yin  <yichao.yin@torchmobile.com.cn>
 

trunk/WebCore/ChangeLog

@@ +1 @@
+2009-05-19  Antti Koivisto  <antti@apple.com>
+
+        Reviewed by Darin Adler).
+        
+        <rdar://problem/6902674> REGRESSION: Query parameters are sometimes incorrect in URL (23135)
+        
+        Push characters back in correct order when entity parsing fails after 3 characters.
+
+        Test: fast/tokenizer/preload-scanner-entities.html
+
+        * html/PreloadScanner.cpp:
+        (WebCore::PreloadScanner::consumeEntity):
+
 2009-05-19  Paul Godavari  <paul@chromium.org>
 

trunk/WebCore/html/PreloadScanner.cpp

@@ -227 +227 @@
                 result = 10 + cc - 'A';
             else {
+                source.push('#');
                 source.push(seenChars[1]);
-                source.push('#');
                 return 0;
             }
@@ -282 +282 @@
                 source.push(seenChars[0]);
             else if (seenChars.size() == 3) {
+                source.push(seenChars[0]);
                 source.push(seenChars[1]);
-                source.push(seenChars[0]);
             } else
                 source.prepend(SegmentedString(String(seenChars.data(), seenChars.size() - 1)));