Changeset 52074 in webkit

Timestamp:

Dec 13, 2009 4:14:13 PM (14 years ago)

Author:

mitz@apple.com

Message:

Add a style guideline concerning floating point literals
​https://bugs.webkit.org/show_bug.cgi?id=32497

Reviewed by Sam Weinig.

• coding/coding-style.html:

Location:

trunk/WebKitSite

Files:

• ChangeLog (modified) (1 diff)
• coding/coding-style.html (modified) (1 diff)

trunk/WebKitSite/ChangeLog

@@ +1 @@
+2009-12-13  Dan Bernstein  <mitz@apple.com>
+
+        Reviewed by Sam Weinig.
+
+        Add a style guideline concerning floating point literals
+        https://bugs.webkit.org/show_bug.cgi?id=32497
+
+        * coding/coding-style.html:
+
 2009-12-09  Marwan Al Jubeh  <marwan.aljubeh@gmail.com>
 

trunk/WebKitSite/coding/coding-style.html

@@ -422 +422 @@
 </li>
 <li>In Objective-C, instance variables are initialized to zero automatically. Don't add explicit initializations to nil or NO in an init method.</li>
+</ol>
+
+<h3>Floating point literals</h3>
+<ol>
+<li>Unless required in order to force floating point math, do not append
+<code>.0</code>, <code>.f</code> and <code>.0f</code> to floating point
+literals.
+
+<h4 class="right">Right:</h4>
+<pre class="code">
+const double duration = 60;
+
+void setDiameter(float diameter)
+{
+    radius = diameter / 2;
+}
+
+setDiameter(10);
+
+const int framesPerSecond = 12;
+double frameDuration = 1.0 / framesPerSecond;
+</pre>
+
+<h4 class="wrong">Wrong:</h4>
+<pre class="code">
+const double duration = 60.0;
+
+void setDiameter(float diameter)
+{
+    radius = diameter / 2.f;
+}
+
+setDiameter(10.f);
+
+const int framesPerSecond = 12;
+double frameDuration = 1 / framesPerSecond; // integer division
+</pre>
+</li>
 </ol>