Changeset 52683 in webkit


Ignore:
Timestamp:
Dec 31, 2009, 10:41:23 AM (15 years ago)
Author:
mitz@apple.com
Message:

<rdar://problem/7503279> REGRESSION (r47440): Incomplete repaint at macworldexpo.com
​https://bugs.webkit.org/show_bug.cgi?id=33067

Reviewed by Simon Fraser.

WebCore:

Test: fast/repaint/table-cell-overflow.html

  • rendering/RenderTableCell.h:

(WebCore::RenderTableCell::hasVisibleOverflow): Added.

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::layoutRows): Set m_hasOverflowingCell if
any cell has visible overflow, like it was before r47440.

LayoutTests:

  • fast/repaint/table-cell-overflow-expected.checksum: Added.
  • fast/repaint/table-cell-overflow-expected.png: Added.
  • fast/repaint/table-cell-overflow-expected.txt: Added.
  • fast/repaint/table-cell-overflow.html: Added.
Location:
trunk
Files:
4 added
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r52671 r52683  
     12009-12-31  Dan Bernstein  <mitz@apple.com>
     2
     3        Reviewed by Simon Fraser.
     4
     5        <rdar://problem/7503279> REGRESSION (r47440): Incomplete repaint at macworldexpo.com
     6        https://bugs.webkit.org/show_bug.cgi?id=33067
     7
     8        * fast/repaint/table-cell-overflow-expected.checksum: Added.
     9        * fast/repaint/table-cell-overflow-expected.png: Added.
     10        * fast/repaint/table-cell-overflow-expected.txt: Added.
     11        * fast/repaint/table-cell-overflow.html: Added.
     12
    1132009-12-30  Dirk Schulze  <krit@webkit.org>
    214

  • trunk/WebCore/ChangeLog

    r52682 r52683  
     12009-12-31  Dan Bernstein  <mitz@apple.com>
     2
     3        Reviewed by Simon Fraser.
     4
     5        <rdar://problem/7503279> REGRESSION (r47440): Incomplete repaint at macworldexpo.com
     6        https://bugs.webkit.org/show_bug.cgi?id=33067
     7
     8        Test: fast/repaint/table-cell-overflow.html
     9
     10        * rendering/RenderTableCell.h:
     11        (WebCore::RenderTableCell::hasVisibleOverflow): Added.
     12        * rendering/RenderTableSection.cpp:
     13        (WebCore::RenderTableSection::layoutRows): Set m_hasOverflowingCell if
     14        any cell has visible overflow, like it was before r47440.
     15
    1162009-12-31  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
    217

  • trunk/WebCore/rendering/RenderTableCell.h

    r51864 r52683  
    100100    virtual void setOverrideSize(int);
    101101
     102    bool hasVisibleOverflow() const { return m_overflow; }
     103
    102104protected:
    103105    virtual void styleWillChange(StyleDifference, const RenderStyle* newStyle);

  • trunk/WebCore/rendering/RenderTableSection.cpp

    r51151 r52683  
    647647                continue;
    648648            addOverflowFromChild(cell);
    649         }
    650     }
    651     m_hasOverflowingCell = m_overflow;
    652    
     649            m_hasOverflowingCell |= cell->hasVisibleOverflow();
     650        }
     651    }
     652
    653653    statePusher.pop();
    654 
    655654    return height();
    656655}
Note: See TracChangeset for help on using the changeset viewer.