Changeset 53432 in webkit

Timestamp:

Jan 18, 2010, 2:20:13 PM (15 years ago)

Author:

mitz@apple.com

Message:

REGRESSION (r53420): incomplete repaint of bottom of bugs.webkit.org comment field
​https://bugs.webkit.org/show_bug.cgi?id=33809

Reviewed by Darin Adler.

WebCore:

Test: fast/repaint/trailing-floats-root-line-box-overflow.html

• rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::layoutInlineChildren): Copy bottom overflow from the last
root box to the trailing floats box, which is becoming the last root box. This is
needed because painting code assumes that the last line in a block is the one with the
lowest overflow bottom.

LayoutTests:

• fast/repaint/trailing-floats-root-line-box-overflow-expected.checksum: Added.
• fast/repaint/trailing-floats-root-line-box-overflow-expected.png: Added.
• fast/repaint/trailing-floats-root-line-box-overflow-expected.txt: Added.
• fast/repaint/trailing-floats-root-line-box-overflow.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/repaint/trailing-floats-root-line-box-overflow-expected.checksum (added)
• LayoutTests/fast/repaint/trailing-floats-root-line-box-overflow-expected.png (added)
• LayoutTests/fast/repaint/trailing-floats-root-line-box-overflow-expected.txt (added)
• LayoutTests/fast/repaint/trailing-floats-root-line-box-overflow.html (added)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/rendering/RenderBlockLineLayout.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2010-01-18  Dan Bernstein  <mitz@apple.com>
+
+        Reviewed by Darin Adler.
+
+        REGRESSION (r53420): incomplete repaint of bottom of bugs.webkit.org comment field
+        https://bugs.webkit.org/show_bug.cgi?id=33809
+
+        * fast/repaint/trailing-floats-root-line-box-overflow-expected.checksum: Added.
+        * fast/repaint/trailing-floats-root-line-box-overflow-expected.png: Added.
+        * fast/repaint/trailing-floats-root-line-box-overflow-expected.txt: Added.
+        * fast/repaint/trailing-floats-root-line-box-overflow.html: Added.
+
 2010-01-18  Alexey Proskuryakov  <ap@apple.com>
 

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-01-18  Dan Bernstein  <mitz@apple.com>
+
+        Reviewed by Darin Adler.
+
+        REGRESSION (r53420): incomplete repaint of bottom of bugs.webkit.org comment field
+        https://bugs.webkit.org/show_bug.cgi?id=33809
+
+        Test: fast/repaint/trailing-floats-root-line-box-overflow.html
+
+        * rendering/RenderBlockLineLayout.cpp:
+        (WebCore::RenderBlock::layoutInlineChildren): Copy bottom overflow from the last
+        root box to the trailing floats box, which is becoming the last root box. This is
+        needed because painting code assumes that the last line in a block is the one with the
+        lowest overflow bottom.
+
 2010-01-18  Csaba Osztrogonác  <ossy@webkit.org>
 

trunk/WebCore/rendering/RenderBlockLineLayout.cpp

@@ -1128 +1128 @@
             // include the padding incorrectly. -dwh
             if (checkForFloatsFromLastLine) {
+                int bottomVisualOverflow = lastRootBox()->bottomVisualOverflow();
+                int bottomLayoutOverflow = lastRootBox()->bottomLayoutOverflow();
                 TrailingFloatsRootInlineBox* trailingFloatsLineBox = new (renderArena()) TrailingFloatsRootInlineBox(this);
                 m_lineBoxes.appendLineBox(trailingFloatsLineBox);
                 trailingFloatsLineBox->setConstructed();
                 trailingFloatsLineBox->verticallyAlignBoxes(height());
+                trailingFloatsLineBox->setVerticalOverflowPositions(height(), bottomLayoutOverflow, height(), bottomVisualOverflow, 0);
                 trailingFloatsLineBox->setBlockHeight(height());
             }