Changeset 54311 in webkit


Ignore:
Timestamp:
Feb 3, 2010, 4:26:00 PM (15 years ago)
Author:
mitz@apple.com
Message:

<rdar://problem/7577604> Drag and Drop: background elements are bleeding through
https://bugs.webkit.org/show_bug.cgi?id=34546

Reviewed by Simon Fraser.

  • manual-tests/drag-image-table-part-decorations.html: Added.
  • rendering/RenderFieldset.cpp:

(WebCore::RenderFieldset::paintBoxDecorations): Bail out if this object shouldn’t
paint within the current painting root.

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::paintBoxDecorations): Ditto.

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::paintBackgroundsBehindCell): Ditto.
(WebCore::RenderTableCell::paintBoxDecorations): Ditto.

Location:
trunk/WebCore
Files:
1 added
4 edited

Legend:

Unmodified
Added
Removed
  • trunk/WebCore/ChangeLog

    r54306 r54311  
     12010-02-03  Dan Bernstein  <mitz@apple.com>
     2
     3        Reviewed by Simon Fraser.
     4
     5        <rdar://problem/7577604> Drag and Drop: background elements are bleeding through
     6        https://bugs.webkit.org/show_bug.cgi?id=34546
     7
     8        * manual-tests/drag-image-table-part-decorations.html: Added.
     9        * rendering/RenderFieldset.cpp:
     10        (WebCore::RenderFieldset::paintBoxDecorations): Bail out if this object shouldn’t
     11        paint within the current painting root.
     12        * rendering/RenderTable.cpp:
     13        (WebCore::RenderTable::paintBoxDecorations): Ditto.
     14        * rendering/RenderTableCell.cpp:
     15        (WebCore::RenderTableCell::paintBackgroundsBehindCell): Ditto.
     16        (WebCore::RenderTableCell::paintBoxDecorations): Ditto.
     17
    1182010-02-03  Nate Chapin  <japhet@chromium.org>
    219
  • trunk/WebCore/rendering/RenderFieldset.cpp

    r50583 r54311  
    120120void RenderFieldset::paintBoxDecorations(PaintInfo& paintInfo, int tx, int ty)
    121121{
     122    if (!shouldPaintWithinRoot(paintInfo))
     123        return;
     124
    122125    int w = width();
    123126    int h = height();
  • trunk/WebCore/rendering/RenderTable.cpp

    r47517 r54311  
    486486void RenderTable::paintBoxDecorations(PaintInfo& paintInfo, int tx, int ty)
    487487{
     488    if (!shouldPaintWithinRoot(paintInfo))
     489        return;
     490
    488491    int w = width();
    489492    int h = height();
  • trunk/WebCore/rendering/RenderTableCell.cpp

    r53291 r54311  
    788788void RenderTableCell::paintBackgroundsBehindCell(PaintInfo& paintInfo, int tx, int ty, RenderObject* backgroundObject)
    789789{
     790    if (!shouldPaintWithinRoot(paintInfo))
     791        return;
     792
    790793    if (!backgroundObject)
    791794        return;
     
    827830void RenderTableCell::paintBoxDecorations(PaintInfo& paintInfo, int tx, int ty)
    828831{
     832    if (!shouldPaintWithinRoot(paintInfo))
     833        return;
     834
    829835    RenderTable* tableElt = table();
    830836    if (!tableElt->collapseBorders() && style()->emptyCells() == HIDE && !firstChild())
Note: See TracChangeset for help on using the changeset viewer.