Changeset 54311 in webkit

Timestamp:

Feb 3, 2010, 4:26:00 PM (15 years ago)

Author:

mitz@apple.com

Message:

<rdar://problem/7577604> Drag and Drop: background elements are bleeding through
​https://bugs.webkit.org/show_bug.cgi?id=34546

Reviewed by Simon Fraser.

• manual-tests/drag-image-table-part-decorations.html: Added.
• rendering/RenderFieldset.cpp:

(WebCore::RenderFieldset::paintBoxDecorations): Bail out if this object shouldn’t
paint within the current painting root.

• rendering/RenderTable.cpp:

(WebCore::RenderTable::paintBoxDecorations): Ditto.

• rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::paintBackgroundsBehindCell): Ditto.
(WebCore::RenderTableCell::paintBoxDecorations): Ditto.

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• manual-tests/drag-image-table-part-decorations.html (added)
• rendering/RenderFieldset.cpp (modified) (1 diff)
• rendering/RenderTable.cpp (modified) (1 diff)
• rendering/RenderTableCell.cpp (modified) (2 diffs)

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-02-03  Dan Bernstein  <mitz@apple.com>
+
+        Reviewed by Simon Fraser.
+
+        <rdar://problem/7577604> Drag and Drop: background elements are bleeding through
+        https://bugs.webkit.org/show_bug.cgi?id=34546
+
+        * manual-tests/drag-image-table-part-decorations.html: Added.
+        * rendering/RenderFieldset.cpp:
+        (WebCore::RenderFieldset::paintBoxDecorations): Bail out if this object shouldn’t
+        paint within the current painting root.
+        * rendering/RenderTable.cpp:
+        (WebCore::RenderTable::paintBoxDecorations): Ditto.
+        * rendering/RenderTableCell.cpp:
+        (WebCore::RenderTableCell::paintBackgroundsBehindCell): Ditto.
+        (WebCore::RenderTableCell::paintBoxDecorations): Ditto.
+
 2010-02-03  Nate Chapin  <japhet@chromium.org>
 

trunk/WebCore/rendering/RenderFieldset.cpp

@@ -120 +120 @@
 void RenderFieldset::paintBoxDecorations(PaintInfo& paintInfo, int tx, int ty)
 {
+    if (!shouldPaintWithinRoot(paintInfo))
+        return;
+
     int w = width();
     int h = height();

trunk/WebCore/rendering/RenderTable.cpp

@@ -486 +486 @@
 void RenderTable::paintBoxDecorations(PaintInfo& paintInfo, int tx, int ty)
 {
+    if (!shouldPaintWithinRoot(paintInfo))
+        return;
+
     int w = width();
     int h = height();

trunk/WebCore/rendering/RenderTableCell.cpp

@@ -788 +788 @@
 void RenderTableCell::paintBackgroundsBehindCell(PaintInfo& paintInfo, int tx, int ty, RenderObject* backgroundObject)
 {
+    if (!shouldPaintWithinRoot(paintInfo))
+        return;
+
     if (!backgroundObject)
         return;
@@ -827 +830 @@
 void RenderTableCell::paintBoxDecorations(PaintInfo& paintInfo, int tx, int ty)
 {
+    if (!shouldPaintWithinRoot(paintInfo))
+        return;
+
     RenderTable* tableElt = table();
     if (!tableElt->collapseBorders() && style()->emptyCells() == HIDE && !firstChild())