Changeset 56673 in webkit

Timestamp:

Mar 27, 2010 5:59:12 PM (14 years ago)

Author:

mitz@apple.com

Message:

WebCore: <rdar://problem/7801598> REGRESSION (r56182): iWeb shadow drawn around image rectangle, not around opaque part of the image
​https://bugs.webkit.org/show_bug.cgi?id=36700

Reviewed by Darin Adler.

• css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::createColor): Reverted to returning an RGB color value rather than an
identifier for the transparent color.

LayoutTests: Updated results and one test for
<rdar://problem/7801598> REGRESSION (r56182): iWeb shadow drawn around image rectangle, not around opaque part of the image
​https://bugs.webkit.org/show_bug.cgi?id=36700

Reviewed by Darin Adler.

• fast/css/getComputedStyle/computed-style-expected.txt:
• fast/css/invalid-import-rule-insertion.html:
• http/tests/mime/standard-mode-does-not-load-stylesheet-with-text-plain-and-css-extension-expected.txt:
• http/tests/mime/standard-mode-does-not-load-stylesheet-with-text-plain-expected.txt:
• http/tests/security/cross-origin-css-expected.txt:
• http/tests/security/cross-origin-css-in-xml-expected.txt:
• platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
• platform/qt/fast/css/getComputedStyle/computed-style-expected.txt:
• platform/win/fast/css/getComputedStyle/computed-style-expected.txt:
• svg/css/getComputedStyle-basic-expected.txt:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/css/getComputedStyle/computed-style-expected.txt (modified) (1 diff)
• LayoutTests/fast/css/invalid-import-rule-insertion.html (modified) (1 diff)
• LayoutTests/http/tests/mime/standard-mode-does-not-load-stylesheet-with-text-plain-and-css-extension-expected.txt (modified) (1 diff)
• LayoutTests/http/tests/mime/standard-mode-does-not-load-stylesheet-with-text-plain-expected.txt (modified) (1 diff)
• LayoutTests/http/tests/security/cross-origin-css-expected.txt (modified) (1 diff)
• LayoutTests/http/tests/security/cross-origin-css-in-xml-expected.txt (modified) (1 diff)
• LayoutTests/platform/mac/fast/css/getComputedStyle/computed-style-expected.txt (modified) (1 diff)
• LayoutTests/platform/qt/fast/css/getComputedStyle/computed-style-expected.txt (modified) (1 diff)
• LayoutTests/platform/win/fast/css/getComputedStyle/computed-style-expected.txt (modified) (1 diff)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/css/CSSPrimitiveValue.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2010-03-27  Dan Bernstein  <mitz@apple.com>
+
+        Reviewed by Darin Adler.
+
+        Updated results and one test for
+        <rdar://problem/7801598> REGRESSION (r56182): iWeb shadow drawn around image rectangle, not around opaque part of the image
+        https://bugs.webkit.org/show_bug.cgi?id=36700
+
+        * fast/css/getComputedStyle/computed-style-expected.txt:
+        * fast/css/invalid-import-rule-insertion.html:
+        * http/tests/mime/standard-mode-does-not-load-stylesheet-with-text-plain-and-css-extension-expected.txt:
+        * http/tests/mime/standard-mode-does-not-load-stylesheet-with-text-plain-expected.txt:
+        * http/tests/security/cross-origin-css-expected.txt:
+        * http/tests/security/cross-origin-css-in-xml-expected.txt:
+        * platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
+        * platform/qt/fast/css/getComputedStyle/computed-style-expected.txt:
+        * platform/win/fast/css/getComputedStyle/computed-style-expected.txt:
+        * svg/css/getComputedStyle-basic-expected.txt:
+
 2010-03-27  Mark Rowe  <mrowe@apple.com>
 

trunk/LayoutTests/fast/css/getComputedStyle/computed-style-expected.txt

@@ -2 +2 @@
 
 background-attachment: scroll;
-background-color: transparent;
+background-color: rgba(0, 0, 0, 0);
 background-image: none;
 background-position: 0% 0%;

trunk/LayoutTests/fast/css/invalid-import-rule-insertion.html

@@ -21 +21 @@
         catch(e)
         {
-            if(window.getComputedStyle(document.body, "").getPropertyValue("background-color") == "transparent" && document.styleSheets[0].cssRules.length == 2)
+            if(window.getComputedStyle(document.body, "").getPropertyValue("background-color") == "rgba(0, 0, 0, 0)" && document.styleSheets[0].cssRules.length == 2)
             {
                 document.getElementById("testresult").innerHTML = "Pass";

trunk/LayoutTests/http/tests/mime/standard-mode-does-not-load-stylesheet-with-text-plain-and-css-extension-expected.txt

@@ -1 @@
-This test passes if we do NOT apply the stylesheet (which turns the background color red.) The background color is: transparent.
+This test passes if we do NOT apply the stylesheet (which turns the background color red.) The background color is: rgba(0, 0, 0, 0).

trunk/LayoutTests/http/tests/mime/standard-mode-does-not-load-stylesheet-with-text-plain-expected.txt

@@ -1 @@
-This test passes if we do NOT apply the stylesheet (which turns the background color red.) The background color is: transparent.
+This test passes if we do NOT apply the stylesheet (which turns the background color red.) The background color is: rgba(0, 0, 0, 0).

trunk/LayoutTests/http/tests/security/cross-origin-css-expected.txt

@@ -1 +1 @@
 LINK Cross-origin, HTML, valid: rgb(255, 255, 0)
-LINK + IMPORT Cross-origin, HTML, invalid: transparent
+LINK + IMPORT Cross-origin, HTML, invalid: rgba(0, 0, 0, 0)
 LINK Cross-origin, CSS, invalid: rgb(255, 255, 0)
 LINK Same-origin, HTML, invalid: rgb(255, 255, 0)

trunk/LayoutTests/http/tests/security/cross-origin-css-in-xml-expected.txt

@@ -1 @@
-XML CSS Same-origin, HTML, valid: transparent
+XML CSS Same-origin, HTML, valid: rgba(0, 0, 0, 0)

trunk/LayoutTests/platform/mac/fast/css/getComputedStyle/computed-style-expected.txt

@@ -3 +3 @@
 background-attachment: scroll;
 background-clip: border-box;
-background-color: transparent;
+background-color: rgba(0, 0, 0, 0);
 background-image: none;
 background-origin: padding-box;

trunk/LayoutTests/platform/qt/fast/css/getComputedStyle/computed-style-expected.txt

@@ -3 +3 @@
 background-attachment: scroll;
 background-clip: border-box;
-background-color: transparent;
+background-color: rgba(0, 0, 0, 0);
 background-image: none;
 background-origin: padding-box;

trunk/LayoutTests/platform/win/fast/css/getComputedStyle/computed-style-expected.txt

@@ -3 +3 @@
 background-attachment: scroll;
 background-clip: border-box;
-background-color: transparent;
+background-color: rgba(0, 0, 0, 0);
 background-image: none;
 background-origin: padding-box;

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-03-27  Dan Bernstein  <mitz@apple.com>
+
+        Reviewed by Darin Adler.
+
+        <rdar://problem/7801598> REGRESSION (r56182): iWeb shadow drawn around image rectangle, not around opaque part of the image
+        https://bugs.webkit.org/show_bug.cgi?id=36700
+
+        * css/CSSPrimitiveValue.cpp:
+        (WebCore::CSSPrimitiveValue::createColor): Reverted to returning an RGB color value rather than an
+        identifier for the transparent color.
+
 2010-03-26  Joseph Pecoraro  <joepeck@webkit.org>
 

trunk/WebCore/css/CSSPrimitiveValue.cpp

@@ -69 +69 @@
     // These are the empty and deleted values of the hash table.
     if (rgbValue == Color::transparent) {
-        static CSSPrimitiveValue* colorTransparent = new CSSPrimitiveValue(CSSValueTransparent);
+        static CSSPrimitiveValue* colorTransparent = new CSSPrimitiveValue(Color::transparent);
         return colorTransparent;
     }