Changeset 61410 in webkit

Timestamp:

Jun 18, 2010 8:55:44 AM (14 years ago)

Author:

mitz@apple.com

Message:

REGRESSION (r61379?): Assertion failure in Element::getURLAttribute() when accessing the src attribute of a script element
​https://bugs.webkit.org/show_bug.cgi?id=40831

Reviewed by Anders Carlsson.

WebCore:

Test: fast/dom/HTMLScriptElement/isURLAttribute.html

• html/HTMLScriptElement.cpp:

(WebCore::HTMLScriptElement::isURLAttribute): Check for the 'src' attribute.

LayoutTests:

• fast/dom/HTMLScriptElement/isURLAttribute-expected.txt: Added.
• fast/dom/HTMLScriptElement/isURLAttribute.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/dom/HTMLScriptElement/isURLAttribute-expected.txt (added)
• LayoutTests/fast/dom/HTMLScriptElement/isURLAttribute.html (added)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/html/HTMLScriptElement.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2010-06-18  Dan Bernstein  <mitz@apple.com>
+
+        Reviewed by Anders Carlsson.
+
+        REGRESSION (r61379?): Assertion failure in Element::getURLAttribute() when accessing the src attribute of a script element
+        https://bugs.webkit.org/show_bug.cgi?id=40831
+
+        * fast/dom/HTMLScriptElement/isURLAttribute-expected.txt: Added.
+        * fast/dom/HTMLScriptElement/isURLAttribute.html: Added.
+
 2010-06-18  Dimitri Glazkov  <dglazkov@chromium.org>
 

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-06-18  Dan Bernstein  <mitz@apple.com>
+
+        Reviewed by Anders Carlsson.
+
+        REGRESSION (r61379?): Assertion failure in Element::getURLAttribute() when accessing the src attribute of a script element
+        https://bugs.webkit.org/show_bug.cgi?id=40831
+
+        Test: fast/dom/HTMLScriptElement/isURLAttribute.html
+
+        * html/HTMLScriptElement.cpp:
+        (WebCore::HTMLScriptElement::isURLAttribute): Check for the 'src' attribute.
+
 2010-06-18  Sheriff Bot  <webkit.review.bot@gmail.com>
 

trunk/WebCore/html/HTMLScriptElement.cpp

@@ -51 +51 @@
 bool HTMLScriptElement::isURLAttribute(Attribute* attr) const
 {
-    return attr->name() == sourceAttributeValue();
+    return attr->name() == srcAttr;
 }