Changeset 62510 in webkit

Timestamp:

Jul 5, 2010, 5:11:08 PM (15 years ago)

Author:

mitz@apple.com

Message:

optimizeLegibility doesn't play nice with fonts that do not have a space glyph
​https://bugs.webkit.org/show_bug.cgi?id=41599

Reviewed by Sam Weinig.

No test because none of the fonts available to DumpRenderTree are missing a space glyph.

• rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::findNextLineBreak): When the font does not map the space character
to a glyph, a fallback font is used for space. Therefore, wordTrailingSpaceWidth must be
initialized with the width of a space as measured by the Font rather than with the cached
space width.

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• rendering/RenderBlockLineLayout.cpp (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-07-05  Dan Bernstein  <mitz@apple.com>
+
+        Reviewed by Sam Weinig.
+
+        optimizeLegibility doesn't play nice with fonts that do not have a space glyph
+        https://bugs.webkit.org/show_bug.cgi?id=41599
+
+        No test because none of the fonts available to DumpRenderTree are missing a space glyph.
+
+        * rendering/RenderBlockLineLayout.cpp:
+        (WebCore::RenderBlock::findNextLineBreak): When the font does not map the space character
+        to a glyph, a fallback font is used for space. Therefore, wordTrailingSpaceWidth must be
+        initialized with the width of a space as measured by the Font rather than with the cached
+        space width.
+
 2010-07-05  Eric Seidel  <eric@webkit.org>
 

trunk/WebCore/rendering/RenderBlockLineLayout.cpp

@@ -1574 +1574 @@
             // Non-zero only when kerning is enabled, in which case we measure words with their trailing
             // space, then subtract its width.
-            int wordTrailingSpaceWidth = f.typesettingFeatures() & Kerning ? f.spaceWidth() + wordSpacing : 0;
+            int wordTrailingSpaceWidth = f.typesettingFeatures() & Kerning ? f.width(TextRun(&space, 1)) + wordSpacing : 0;
 
             int wrapW = tmpW + inlineWidth(o, !appliedStartWidth, true);