Changeset 62513 in webkit


Ignore:
Timestamp:
Jul 5, 2010, 6:06:05 PM (15 years ago)
Author:
mitz@apple.com
Message:

Reproducible crash with Optimize Legibility extension
​https://bugs.webkit.org/show_bug.cgi?id=41585

Reviewed by Sam Weinig.

WebCore:

Test: fast/css/text-rendering-priority.html

Moved the text-rendering CSS property to the “high priority” group, because applying it
during style selection invalidates the font.

  • css/CSSPropertyNames.in: Moved text-rendering to the “high priority” section at the top.
  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyDeclarations): Updated compile-time assertion.

LayoutTests:

  • fast/css/text-rendering-priority-expected.txt: Added.
  • fast/css/text-rendering-priority.html: Added.
Location:
trunk
Files:
2 added
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r62512 r62513  
     12010-07-05  Dan Bernstein  <mitz@apple.com>
     2
     3        Reviewed by Sam Weinig.
     4
     5        Reproducible crash with Optimize Legibility extension
     6        https://bugs.webkit.org/show_bug.cgi?id=41585
     7
     8        * fast/css/text-rendering-priority-expected.txt: Added.
     9        * fast/css/text-rendering-priority.html: Added.
     10
    1112010-07-05  Alice Liu  <alice.liu@apple.com>
    212

  • trunk/WebCore/ChangeLog

    r62510 r62513  
     12010-07-05  Dan Bernstein  <mitz@apple.com>
     2
     3        Reviewed by Sam Weinig.
     4
     5        Reproducible crash with Optimize Legibility extension
     6        https://bugs.webkit.org/show_bug.cgi?id=41585
     7
     8        Test: fast/css/text-rendering-priority.html
     9
     10        Moved the text-rendering CSS property to the “high priority” group, because applying it
     11        during style selection invalidates the font.
     12
     13        * css/CSSPropertyNames.in: Moved text-rendering to the “high priority” section at the top.
     14        * css/CSSStyleSelector.cpp:
     15        (WebCore::CSSStyleSelector::applyDeclarations): Updated compile-time assertion.
     16
    1172010-07-05  Dan Bernstein  <mitz@apple.com>
    218

  • trunk/WebCore/css/CSSPropertyNames.in

    r61548 r62513  
    2020font-variant
    2121font-weight
     22text-rendering
    2223-webkit-text-size-adjust
    2324zoom
    … …  
    135136text-overline-style
    136137text-overline-width
    137 text-rendering
    138138text-shadow
    139139text-transform

  • trunk/WebCore/css/CSSStyleSelector.cpp

    r61975 r62513  
    29212921                if (applyFirst) {
    29222922                    COMPILE_ASSERT(firstCSSProperty == CSSPropertyColor, CSS_color_is_first_property);
    2923                     COMPILE_ASSERT(CSSPropertyZoom == CSSPropertyColor + 10, CSS_zoom_is_end_of_first_prop_range);
     2923                    COMPILE_ASSERT(CSSPropertyZoom == CSSPropertyColor + 11, CSS_zoom_is_end_of_first_prop_range);
    29242924                    COMPILE_ASSERT(CSSPropertyLineHeight == CSSPropertyZoom + 1, CSS_line_height_is_after_zoom);
    29252925
Note: See TracChangeset for help on using the changeset viewer.