Changeset 63463 in webkit

Timestamp:

Jul 15, 2010, 2:38:32 PM (15 years ago)

Author:

Stephanie Lewis

Message:

SunSpider: ​http://bugs.webkit.org/show_bug.cgi?id=42406
Output location of results file.

Reviewed by Geoff Garen.

• sunspider:

WebKitTools: ​http://bugs.webkit.org/show_bug.cgi?id=42406
Make SunSpider work better with roots.

Reviewed by Geoff Garen.

• Scripts/sunspider-compare-results: fix argument bug
• Scripts/webkitdirs.pm: look inside JavaScriptCore if jsc isn't top-level.

Location:

trunk

Files:

• SunSpider/ChangeLog (modified) (1 diff)
• SunSpider/sunspider (modified) (1 diff)
• WebKitTools/ChangeLog (modified) (1 diff)
• WebKitTools/Scripts/sunspider-compare-results (modified) (1 diff)
• WebKitTools/Scripts/webkitdirs.pm (modified) (1 diff)

trunk/SunSpider/ChangeLog

@@ +1 @@
+2010-07-15  Stephanie Lewis  <slewis@apple.com>
+
+        Reviewed by Geoff Garen.
+
+        http://bugs.webkit.org/show_bug.cgi?id=42406
+        Output location of results file.
+
+        * sunspider:
+
 2010-05-17  Maciej Stachowiak  <mjs@apple.com>
 

trunk/SunSpider/sunspider

@@ -230 +230 @@
 system("$jsShellPath", "-f", $prefixFile, "-f", $resultsFile, "-f", "resources/sunspider-analyze-results.js");
 
+print("\nResults are located at $resultsFile\n");
+
 if ($runShark) {
     my $newestMShark = newestFile(".", qr/\.mshark$/);

trunk/WebKitTools/ChangeLog

@@ +1 @@
+2010-07-15  Stephanie Lewis  <slewis@apple.com>
+
+        Reviewed by Geoff Garen.
+
+        http://bugs.webkit.org/show_bug.cgi?id=42406
+        Make SunSpider work better with roots.
+
+        * Scripts/sunspider-compare-results: fix argument bug
+        * Scripts/webkitdirs.pm: look inside JavaScriptCore if jsc isn't top-level.
+
 2010-07-15  Brady Eidson  <beidson@apple.com>
 

trunk/WebKitTools/Scripts/sunspider-compare-results

@@ -56 +56 @@
 EOF
 
-GetOptions('root=s' => sub { my ($argName, $value); setConfigurationProductDir(Cwd::abs_path($value)); },
+GetOptions('root=s' => sub { my ($argName, $value) = @_; setConfigurationProductDir(Cwd::abs_path($value)); },
            'suite=s' => \$suite,
            'ubench' => \$ubench,

trunk/WebKitTools/Scripts/webkitdirs.pm

@@ -259 +259 @@
     my $jscName = "jsc";
     $jscName .= "_debug"  if (isCygwin() && ($configuration eq "Debug"));
-    return "$productDir/$jscName";
+    return "$productDir/$jscName" if -e "$productDir/$jscName";
+    return "$productDir/JavaScriptCore.framework/Resources/$jscName";
 }