Changeset 63672 in webkit


Ignore:
Timestamp:
Jul 19, 2010 9:48:36 AM (14 years ago)
Author:
mitz@apple.com
Message:

<rdar://problem/7232109> Unpainted white area appears at the edge of the page when body has bg color
https://bugs.webkit.org/show_bug.cgi?id=34913

Reviewed by Simon Fraser.

WebCore:

Tests: fast/repaint/view-background-from-body-1.html

fast/repaint/view-background-from-body-2.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::styleWillChange): If this is the body renderer and its current style is
null, repaint the view, similarly to how the view is repainted for any repaint-or-higher
style changes.

  • rendering/RenderObjectChildList.cpp:

(WebCore::RenderObjectChildList::removeChildNode): If the removed child is the body renderer,
repaint the view, in case the body’s background was propagated to the view.

LayoutTests:

  • fast/repaint/view-background-from-body-1.html: Added.
  • fast/repaint/view-background-from-body-2.html: Added.
  • platform/mac/fast/repaint/view-background-from-body-1-expected.checksum: Added.
  • platform/mac/fast/repaint/view-background-from-body-1-expected.png: Added.
  • platform/mac/fast/repaint/view-background-from-body-1-expected.txt: Added.
  • platform/mac/fast/repaint/view-background-from-body-2-expected.checksum: Added.
  • platform/mac/fast/repaint/view-background-from-body-2-expected.png: Added.
  • platform/mac/fast/repaint/view-background-from-body-2-expected.txt: Added.
Location:
trunk
Files:
8 added
4 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r63664 r63672  
     12010-07-19  Dan Bernstein  <mitz@apple.com>
     2
     3        Reviewed by Simon Fraser.
     4
     5        <rdar://problem/7232109> Unpainted white area appears at the edge of the page when body has bg color
     6        https://bugs.webkit.org/show_bug.cgi?id=34913
     7
     8        * fast/repaint/view-background-from-body-1.html: Added.
     9        * fast/repaint/view-background-from-body-2.html: Added.
     10        * platform/mac/fast/repaint/view-background-from-body-1-expected.checksum: Added.
     11        * platform/mac/fast/repaint/view-background-from-body-1-expected.png: Added.
     12        * platform/mac/fast/repaint/view-background-from-body-1-expected.txt: Added.
     13        * platform/mac/fast/repaint/view-background-from-body-2-expected.checksum: Added.
     14        * platform/mac/fast/repaint/view-background-from-body-2-expected.png: Added.
     15        * platform/mac/fast/repaint/view-background-from-body-2-expected.txt: Added.
     16
    1172010-07-19  Anders Carlsson  <andersca@apple.com>
    218
  • trunk/WebCore/ChangeLog

    r63667 r63672  
     12010-07-19  Dan Bernstein  <mitz@apple.com>
     2
     3        Reviewed by Simon Fraser.
     4
     5        <rdar://problem/7232109> Unpainted white area appears at the edge of the page when body has bg color
     6        https://bugs.webkit.org/show_bug.cgi?id=34913
     7
     8        Tests: fast/repaint/view-background-from-body-1.html
     9               fast/repaint/view-background-from-body-2.html
     10
     11        * rendering/RenderBox.cpp:
     12        (WebCore::RenderBox::styleWillChange): If this is the body renderer and its current style is
     13        null, repaint the view, similarly to how the view is repainted for any repaint-or-higher
     14        style changes.
     15        * rendering/RenderObjectChildList.cpp:
     16        (WebCore::RenderObjectChildList::removeChildNode): If the removed child is the body renderer,
     17        repaint the view, in case the body’s background was propagated to the view.
     18
    1192010-07-19  Adam Roben  <aroben@apple.com>
    220
  • trunk/WebCore/rendering/RenderBox.cpp

    r62118 r63672  
    44 *           (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com)
    55 *           (C) 2005, 2006 Samuel Weinig (sam.weinig@gmail.com)
    6  * Copyright (C) 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved.
     6 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserved.
    77 *
    88 * This library is free software; you can redistribute it and/or
     
    146146                removeFloatingOrPositionedChildFromBlockLists();
    147147        }
    148     }
     148    } else if (newStyle && isBody())
     149        view()->repaint();
     150
    149151    if (FrameView *frameView = view()->frameView()) {
    150152        bool newStyleIsFixed = newStyle && newStyle->position() == FixedPosition;
  • trunk/WebCore/rendering/RenderObjectChildList.cpp

    r60282 r63672  
    11/*
    2  * Copyright (C) 2009 Apple Inc. All rights reserved.
     2 * Copyright (C) 2009, 2010 Apple Inc. All rights reserved.
    33 *
    44 * Redistribution and use in source and binary forms, with or without
     
    6363    if (!owner->documentBeingDestroyed() && fullRemove && oldChild->m_everHadLayout) {
    6464        oldChild->setNeedsLayoutAndPrefWidthsRecalc();
    65         oldChild->repaint();
    66     }
    67        
     65        if (oldChild->isBody())
     66            owner->view()->repaint();
     67        else
     68            oldChild->repaint();
     69    }
     70
    6871    // If we have a line box wrapper, delete it.
    6972    if (oldChild->isBox())
Note: See TracChangeset for help on using the changeset viewer.