Changeset 68683 in webkit


Ignore:
Timestamp:
Sep 29, 2010, 2:12:44 PM (15 years ago)
Author:
mitz@apple.com
Message:

Removed input type site-specific quirk for mail.google.com
https://bugs.webkit.org/show_bug.cgi?id=46836

Reviewed by Sam Weinig.

  • bindings/js/JSHTMLInputElementCustom.cpp:

(WebCore::needsGmailQuirk): Removed.
(WebCore::JSHTMLInputElement::type): Removed this custom getter.

  • html/HTMLInputElement.idl: Removed the JSCCustomGetter custom attribute

from the type attribute.

Location:
trunk/WebCore
Files:
3 edited

Legend:

Unmodified
Added
Removed
  • TabularUnified trunk/WebCore/ChangeLog

    r68682 r68683  
     12010-09-29  Dan Bernstein  <mitz@apple.com>
     2
     3        Reviewed by Sam Weinig.
     4
     5        Removed input type site-specific quirk for mail.google.com
     6        https://bugs.webkit.org/show_bug.cgi?id=46836
     7
     8        * bindings/js/JSHTMLInputElementCustom.cpp:
     9        (WebCore::needsGmailQuirk): Removed.
     10        (WebCore::JSHTMLInputElement::type): Removed this custom getter.
     11        * html/HTMLInputElement.idl: Removed the JSCCustomGetter custom attribute
     12        from the type attribute.
     13
    1142010-09-29  Joseph Pecoraro  <joepeck@webkit.org>
    215
  • TabularUnified trunk/WebCore/bindings/js/JSHTMLInputElementCustom.cpp

    r60762 r68683  
    2727#include "JSHTMLInputElement.h"
    2828
    29 #include "Document.h"
    3029#include "HTMLInputElement.h"
    31 #include "Settings.h"
    3230#include <runtime/Error.h>
    3331
     
    3533
    3634namespace WebCore {
    37 
    38 static bool needsGmailQuirk(HTMLInputElement* input)
    39 {
    40     Document* document = input->document();
    41 
    42     const KURL& url = document->url();
    43     if (url.host() != "mail.google.com")
    44         return false;
    45 
    46     // As with other site-specific quirks, allow website developers to turn this off.
    47     // In theory, this allows website developers to check if their fixes are effective.
    48     Settings* settings = document->settings();
    49     if (!settings)
    50         return false;
    51     if (!settings->needsSiteSpecificQuirks())
    52         return false;
    53 
    54     return true;
    55 }
    56 
    57 JSValue JSHTMLInputElement::type(ExecState* exec) const
    58 {
    59     HTMLInputElement* input = static_cast<HTMLInputElement*>(impl());
    60     const AtomicString& type = input->type();
    61 
    62     DEFINE_STATIC_LOCAL(const AtomicString, url, ("url"));
    63     DEFINE_STATIC_LOCAL(const AtomicString, text, ("text"));
    64 
    65     if (type == url && needsGmailQuirk(input))
    66         return jsString(exec, text);
    67     return jsString(exec, type);
    68 }
    6935
    7036JSValue JSHTMLInputElement::selectionStart(ExecState* exec) const
  • TabularUnified trunk/WebCore/html/HTMLInputElement.idl

    r68640 r68683  
    5757        attribute [Reflect, URL] DOMString src;
    5858        attribute [Reflect] DOMString step;
    59         attribute [ConvertNullToNullString, JSCCustomGetter] DOMString type; // readonly dropped as part of DOM level 2
     59        attribute [ConvertNullToNullString] DOMString type; // readonly dropped as part of DOM level 2
    6060        attribute [Reflect] DOMString useMap;
    6161        attribute [ConvertNullToNullString] DOMString value;
Note: See TracChangeset for help on using the changeset viewer.