Changeset 68911 in webkit


Ignore:
Timestamp:
Oct 1, 2010 12:16:25 PM (14 years ago)
Author:
mitz@apple.com
Message:

<rdar://problem/7563219> Null dereference when dragging an element with generated content
https://bugs.webkit.org/show_bug.cgi?id=47005

Reviewed by Adele Peterson.

WebCore:

Test: fast/css-generated-content/drag-state.html

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::updateDragState): Null-check node().

LayoutTests:

  • fast/css-generated-content/drag-state-expected.txt: Added.
  • fast/css-generated-content/drag-state.html: Added.
Location:
trunk
Files:
2 added
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r68909 r68911  
     12010-10-01  Dan Bernstein  <mitz@apple.com>
     2
     3        Reviewed by Adele Peterson.
     4
     5        <rdar://problem/7563219> Null dereference when dragging an element with generated content
     6        https://bugs.webkit.org/show_bug.cgi?id=47005
     7
     8        * fast/css-generated-content/drag-state-expected.txt: Added.
     9        * fast/css-generated-content/drag-state.html: Added.
     10
    1112010-10-01  Alpha Lam  <hclam@chromium.org>
    212
  • trunk/WebCore/ChangeLog

    r68906 r68911  
     12010-10-01  Dan Bernstein  <mitz@apple.com>
     2
     3        Reviewed by Adele Peterson.
     4
     5        <rdar://problem/7563219> Null dereference when dragging an element with generated content
     6        https://bugs.webkit.org/show_bug.cgi?id=47005
     7
     8        Test: fast/css-generated-content/drag-state.html
     9
     10        * rendering/RenderObject.cpp:
     11        (WebCore::RenderObject::updateDragState): Null-check node().
     12
    1132010-10-01  Robert Hogan  <robert@webkit.org>
    214
  • trunk/WebCore/rendering/RenderObject.cpp

    r68628 r68911  
    22252225    bool valueChanged = (dragOn != m_isDragging);
    22262226    m_isDragging = dragOn;
    2227     if (valueChanged && style()->affectedByDragRules())
     2227    if (valueChanged && style()->affectedByDragRules() && node())
    22282228        node()->setNeedsStyleRecalc();
    22292229    for (RenderObject* curr = firstChild(); curr; curr = curr->nextSibling())
Note: See TracChangeset for help on using the changeset viewer.