Changeset 71570 in webkit

Timestamp:

Nov 8, 2010, 2:18:05 PM (14 years ago)

Author:

abarth@webkit.org

Message:

2010-11-08 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Restore normal meaning of double-click on patch review page?
​https://bugs.webkit.org/show_bug.cgi?id=47641

After this patch, you need to click on the line numbers to add a
comment.

• PrettyPatch/PrettyPatch.rb:
• code-review.js:

Location:

trunk/BugsSite

Files:

• ChangeLog (modified) (1 diff)
• PrettyPatch/PrettyPatch.rb (modified) (1 diff)
• code-review.js (modified) (1 diff)

trunk/BugsSite/ChangeLog

@@ +1 @@
+2010-11-08  Adam Barth  <abarth@webkit.org>
+
+        Reviewed by Eric Seidel.
+
+        Restore normal meaning of double-click on patch review page?
+        https://bugs.webkit.org/show_bug.cgi?id=47641
+
+        After this patch, you need to click on the line numbers to add a
+        comment.
+
+        * PrettyPatch/PrettyPatch.rb:
+        * code-review.js:
+
 2010-10-09  Adam Barth  <abarth@webkit.org>
 

trunk/BugsSite/PrettyPatch/PrettyPatch.rb

@@ -313 +313 @@
 </style>
 <script src="https://ajax.googleapis.com/ajax/libs/jquery/1.4.2/jquery.min.js"></script> 
-<script src="code-review.js?version=13"></script> 
+<script src="code-review.js?version=14"></script> 
 EOF
 

trunk/BugsSite/code-review.js

@@ -254 +254 @@
 
   function crawlDiff() {
-    $('.Line').each(idify).each(hoverify).dblclick(addCommentField);
+    $('.Line').each(idify).each(hoverify);
     $('.FileDiff').each(function() {
       var file_name = $(this).children('h1').text();