Changeset 76414 in webkit

Timestamp:

Jan 21, 2011, 5:31:05 PM (14 years ago)

Author:

mitz@apple.com

Message:

Inconsistent handling of no-break space in justification logic
​https://bugs.webkit.org/show_bug.cgi?id=52938

Reviewed by Adele Peterson.

Source/WebCore:

Test: fast/text/justify-nbsp.html

• rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::computeInlineDirectionPositionsForLine): Count no-break space as a
space when computing the distribution of space between text boxes on the line.

LayoutTests:

• fast/text/justify-nbsp-expected.checksum: Added.
• fast/text/justify-nbsp-expected.png: Added.
• fast/text/justify-nbsp-expected.txt: Added.
• fast/text/justify-nbsp.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/text/justify-nbsp-expected.checksum (added)
• LayoutTests/fast/text/justify-nbsp-expected.png (added)
• LayoutTests/fast/text/justify-nbsp-expected.txt (added)
• LayoutTests/fast/text/justify-nbsp.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/rendering/RenderBlockLineLayout.cpp (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2011-01-21  Dan Bernstein  <mitz@apple.com>
+
+        Reviewed by Adele Peterson.
+
+        Inconsistent handling of no-break space in justification logic
+        https://bugs.webkit.org/show_bug.cgi?id=52938
+
+        * fast/text/justify-nbsp-expected.checksum: Added.
+        * fast/text/justify-nbsp-expected.png: Added.
+        * fast/text/justify-nbsp-expected.txt: Added.
+        * fast/text/justify-nbsp.html: Added.
+
 2011-01-21  Kenji Imasaki  <imasaki@chromium.org>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-01-21  Dan Bernstein  <mitz@apple.com>
+
+        Reviewed by Adele Peterson.
+
+        Inconsistent handling of no-break space in justification logic
+        https://bugs.webkit.org/show_bug.cgi?id=52938
+
+        Test: fast/text/justify-nbsp.html
+
+        * rendering/RenderBlockLineLayout.cpp:
+        (WebCore::RenderBlock::computeInlineDirectionPositionsForLine): Count no-break space as a
+        space when computing the distribution of space between text boxes on the line.
+
 2011-01-21  Charlie Reis  <creis@chromium.org>
 

trunk/Source/WebCore/rendering/RenderBlockLineLayout.cpp

@@ -326 +326 @@
                 for (int i = r->m_start; i < r->m_stop; i++) {
                     UChar c = characters[i];
-                    if (c == ' ' || c == '\n' || c == '\t')
+                    if (Font::treatAsSpace(c))
                         numSpaces++;
                 }
@@ -448 +448 @@
                 for (int i = r->m_start; i < r->m_stop; i++) {
                     UChar c = characters[i];
-                    if (c == ' ' || c == '\n' || c == '\t')
+                    if (Font::treatAsSpace(c))
                         spaces++;
                 }