Changeset 77452 in webkit

Timestamp:

Feb 2, 2011, 5:58:03 PM (14 years ago)

Author:

Stephanie Lewis

Message:

​https://bugs.webkit.org/show_bug.cgi?id=53361
<rdar://problem/8921729> REGRESSION: Membuster accumulates 1GB+ memory due to autorelease
pools not being drained.
Call into AppKit to add observers that push and pop autorelease pools on entry
and exit from the CFRunLoop. This will prevent memory from accumulating.

Reviewed by Geoff Garen.

• WebProcess/mac/WebProcessMainMac.mm:

(WebKit::WebProcessMain):

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• WebProcess/mac/WebProcessMainMac.mm (modified) (2 diffs)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2011-02-02  Stephanie Lewis  <slewis@apple.com>
+
+        Reviewed by Geoff Garen.
+
+        https://bugs.webkit.org/show_bug.cgi?id=53361
+        <rdar://problem/8921729> REGRESSION: Membuster accumulates 1GB+ memory due to autorelease 
+        pools not being drained.
+        Call into AppKit to add observers that push and pop autorelease pools on entry 
+        and exit from the CFRunLoop.  This will prevent memory from accumulating.
+
+        * WebProcess/mac/WebProcessMainMac.mm:
+        (WebKit::WebProcessMain):
+
 2011-02-02  Darin Adler  <darin@apple.com>
 

trunk/Source/WebKit2/WebProcess/mac/WebProcessMainMac.mm

@@ -47 +47 @@
 extern "C" kern_return_t bootstrap_look_up2(mach_port_t, const name_t, mach_port_t*, pid_t, uint64_t);
 
+@interface NSApplication (WebNSApplicationDetails)
+-(void)_installAutoreleasePoolsOnCurrentThreadIfNecessary;
+@end
+
 #define SHOW_CRASH_REPORTER 1
 
@@ -90 +94 @@
     [NSApplication sharedApplication];
 
+    // Installs autorelease pools on the current CFRunLoop which prevents memory from accumulating between user events.
+    // FIXME: Remove when <rdar://problem/8929426> is fixed.
+    [[NSApplication sharedApplication] _installAutoreleasePoolsOnCurrentThreadIfNecessary];
+
 #if !defined(BUILDING_ON_SNOW_LEOPARD)
     WKAXRegisterRemoteApp();