Changeset 88310 in webkit

Timestamp:

Jun 7, 2011, 6:37:20 PM (15 years ago)

Author:

rniwa@webkit.org

Message:

2011-06-07 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Tony Chang.

new-run-webkit-tests: Bot master should print useful information on waterfall/console for nrwt
​https://bugs.webkit.org/show_bug.cgi?id=62178

Added commandComplete and evaluateCommand for NewRunWebKitTests class
to parse new-run-webkit-tests' results.

• BuildSlaveSupport/build.webkit.org-config/master.cfg:

Location:

trunk/Tools

Files:

• BuildSlaveSupport/build.webkit.org-config/master.cfg (modified) (1 diff)
• ChangeLog (modified) (1 diff)

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg

@@ -268 +268 @@
                WithProperties("--%(configuration)s")]
 
+    def commandComplete(self, cmd):
+        shell.Test.commandComplete(self, cmd)
+
+        logText = cmd.logs['stdio'].getText()
+        incorrectLayoutLines = []
+        expressions = {
+            'failed': re.compile(r'Regressions: Unexpected.+:?\s*\((\d+)\)'),
+            'were flaky': re.compile(r'Unexpected flakiness.+:?\s*\((\d+)\)'),
+            'new passes': re.compile(r'Expected to .+, but passed:\s+\((\d+)\)'),
+        }
+        testFailures = {}
+
+        for line in logText.splitlines():
+            if line.find('Exiting early') >= 0:
+                incorrectLayoutLines.append(line)
+                continue
+            for name in expressions:
+                match = expressions[name].search(line)
+                if match:
+                    testFailures[name] = testFailures.get(name, 0) + int(match.group(1))
+
+                # FIXME: Parse file names and put them in results
+
+        for name in testFailures:
+            incorrectLayoutLines.append(str(testFailures[name]) + ' ' + name)
+
+        self.incorrectLayoutLines = incorrectLayoutLines
+
+    def evaluateCommand(self, cmd):
+        if cmd.rc != 0:
+            return FAILURE
+
+        result = SUCCESS
+        if self.incorrectLayoutLines:
+            for line in incorrectLayoutLines:
+                if result != FAILURE and (line.find('were flaky') >= 0 or line.find('passed unexpectedly') >= 0):
+                    result = WARNINGS
+                else:
+                    result = FAILURE
+
+        return result
 
 class RunPythonTests(shell.Test):

trunk/Tools/ChangeLog

@@ +1 @@
+2011-06-07  Ryosuke Niwa  <rniwa@webkit.org>
+
+        Reviewed by Tony Chang.
+
+        new-run-webkit-tests: Bot master should print useful information on waterfall/console for nrwt
+        https://bugs.webkit.org/show_bug.cgi?id=62178
+
+        Added commandComplete and evaluateCommand for NewRunWebKitTests class
+        to parse new-run-webkit-tests' results.
+
+        * BuildSlaveSupport/build.webkit.org-config/master.cfg:
+
 2011-06-07  Dirk Pranke  <dpranke@chromium.org>