Changeset 89650 in webkit

Timestamp:

Jun 23, 2011, 6:53:29 PM (14 years ago)

Author:

zmo@google.com

Message:

2011-06-23 Zhenyao Mo <​zmo@google.com>

Reviewed by Kenneth Russell.

Limit WebGL internal drawingBuffer size to 4k x 4k
​https://bugs.webkit.org/show_bug.cgi?id=63304

• html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::reshape): Limit drawing buffer size to 4k x 4k.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• html/canvas/WebGLRenderingContext.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-06-23  Zhenyao Mo  <zmo@google.com>
+
+        Reviewed by Kenneth Russell.
+
+        Limit WebGL internal drawingBuffer size to 4k x 4k
+        https://bugs.webkit.org/show_bug.cgi?id=63304
+
+        * html/canvas/WebGLRenderingContext.cpp:
+        (WebCore::WebGLRenderingContext::reshape): Limit drawing buffer size to 4k x 4k.
+
 2011-06-20  MORITA Hajime  <morrita@google.com>
 

trunk/Source/WebCore/html/canvas/WebGLRenderingContext.cpp

@@ -610 +610 @@
     // know if the underlying FBO uses textures or renderbuffers.
     GC3Dint maxSize = std::min(m_maxTextureSize, m_maxRenderbufferSize);
+    // Limit drawing buffer size to 4k to avoid memory exhaustion.
+    const int sizeUpperLimit = 4096;
+    maxSize = std::min(maxSize, sizeUpperLimit);
     GC3Dint maxWidth = std::min(maxSize, m_maxViewportDims[0]);
     GC3Dint maxHeight = std::min(maxSize, m_maxViewportDims[1]);