Changeset 90231 in webkit

Timestamp:

Jul 1, 2011, 9:17:44 AM (15 years ago)

Author:

kbalazs@webkit.org

Message:

2011-07-01 Balazs Kelemen <​kbalazs@webkit.org>

Reviewed by Andreas Kling.

[X11][WK2] plugins/mouse-evets-fixedpos.html is failing because of broken event propagation
​https://bugs.webkit.org/show_bug.cgi?id=63239

• platform/qt-wk2/Skipped:

2011-07-01 Balazs Kelemen <​kbalazs@webkit.org>

Reviewed by Andreas Kling.

[X11][WK2] plugins/mouse-evets-fixedpos.html is failing because of broken event propagation
​https://bugs.webkit.org/show_bug.cgi?id=63239

• WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp: Revert the return value of NPP_HandleEvent because the plugin function returns with 0 if it handled the event. (WebKit::NetscapePlugin::platformHandleMouseEvent): (WebKit::NetscapePlugin::platformHandleWheelEvent): (WebKit::NetscapePlugin::platformHandleMouseEnterEvent): (WebKit::NetscapePlugin::platformHandleMouseLeaveEvent): (WebKit::NetscapePlugin::platformHandleKeyboardEvent):

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/qt-wk2/Skipped (modified) (1 diff)
• Source/WebKit2/ChangeLog (modified) (1 diff)
• Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp (modified) (5 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2011-07-01  Balazs Kelemen  <kbalazs@webkit.org>
+
+        Reviewed by Andreas Kling.
+
+        [X11][WK2] plugins/mouse-evets-fixedpos.html is failing because of broken event propagation
+        https://bugs.webkit.org/show_bug.cgi?id=63239
+
+        * platform/qt-wk2/Skipped:
+
 2011-07-01  Alice Boxhall  <aboxhall@chromium.org>
 

trunk/LayoutTests/platform/qt-wk2/Skipped

@@ -1492 +1492 @@
 # Unexplained plugin failures
 plugins/embed-prefers-plugins-for-images.html
-plugins/mouse-events-fixedpos.html
 plugins/netscape-dom-access.html
 plugins/npp-set-window-called-during-destruction.html

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2011-07-01  Balazs Kelemen  <kbalazs@webkit.org>
+
+        Reviewed by Andreas Kling.
+
+        [X11][WK2] plugins/mouse-evets-fixedpos.html is failing because of broken event propagation
+        https://bugs.webkit.org/show_bug.cgi?id=63239
+
+        * WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:
+        Revert the return value of NPP_HandleEvent because the plugin function
+        returns with 0 if it handled the event.
+        (WebKit::NetscapePlugin::platformHandleMouseEvent):
+        (WebKit::NetscapePlugin::platformHandleWheelEvent):
+        (WebKit::NetscapePlugin::platformHandleMouseEnterEvent):
+        (WebKit::NetscapePlugin::platformHandleMouseLeaveEvent):
+        (WebKit::NetscapePlugin::platformHandleKeyboardEvent):
+
 2011-07-01  Mark Rowe  <mrowe@apple.com>
 

trunk/Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp

@@ -435 +435 @@
     }
 
-    return NPP_HandleEvent(&xEvent);
+    return !NPP_HandleEvent(&xEvent);
 }
 
@@ -454 +454 @@
     setXButtonEventFieldsByWebWheelEvent(xEvent, event, m_frameRect.location());
 
-    return NPP_HandleEvent(&xEvent);
+    return !NPP_HandleEvent(&xEvent);
 }
 
@@ -481 +481 @@
     setXCrossingEventFields(xEvent, event, m_frameRect.location(), EnterNotify);
 
-    return NPP_HandleEvent(&xEvent);
+    return !NPP_HandleEvent(&xEvent);
 }
 
@@ -493 +493 @@
     setXCrossingEventFields(xEvent, event, m_frameRect.location(), LeaveNotify);
 
-    return NPP_HandleEvent(&xEvent);
+    return !NPP_HandleEvent(&xEvent);
 }
 
@@ -525 +525 @@
     setXKeyEventFields(xEvent, event);
 
-    return NPP_HandleEvent(&xEvent);
+    return !NPP_HandleEvent(&xEvent);
 }