Changeset 90238 in webkit

Timestamp:

Jul 1, 2011, 9:51:24 AM (15 years ago)

Author:

bweinstein@apple.com

Message:

WebKit2: DidFinishLoadForFrame is never called on iframes when loads are
cancelled by willSendRequest
​https://bugs.webkit.org/show_bug.cgi?id=63753

Reviewed by Darin Adler.

Source/WebKit2:

When deciding a policy for a null request, call the callback that was passed
to WebKit2 and say that we used the loader.

• WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForResponse):

LayoutTests:

Unskip WebKit2 tests that now pass.

• platform/wk2/Skipped:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/wk2/Skipped (modified) (1 diff)
• Source/WebKit2/ChangeLog (modified) (1 diff)
• Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2011-06-30  Brian Weinstein  <bweinstein@apple.com>
+
+        Reviewed by Darin Adler.
+
+        WebKit2: DidFinishLoadForFrame is never called on iframes when loads are 
+        cancelled by willSendRequest
+        https://bugs.webkit.org/show_bug.cgi?id=63753
+        
+        Unskip WebKit2 tests that now pass.
+
+        * platform/wk2/Skipped:
+
 2011-07-01  Adam Roben  <aroben@apple.com>
 

trunk/LayoutTests/platform/wk2/Skipped

@@ -2049 +2049 @@
 platform/mac/editing/pasteboard/text-precomposed.html
 
-# Unexplained failures after implementing willSendRequestReturnsNull
-fast/loader/onload-willSendRequest-null-for-frame.html
-plugins/plugin-document-willSendRequest-null.html
-
 # An empty layer is missing.
 platform/mac/fast/forms/input-appearance-spinbutton-up.html

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2011-06-30  Brian Weinstein  <bweinstein@apple.com>
+
+        Reviewed by Darin Adler.
+
+        WebKit2: DidFinishLoadForFrame is never called on iframes when loads are 
+        cancelled by willSendRequest
+        https://bugs.webkit.org/show_bug.cgi?id=63753
+        
+        When deciding a policy for a null request, call the callback that was passed
+        to WebKit2 and say that we used the loader.
+
+        * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
+        (WebKit::WebFrameLoaderClient::dispatchDecidePolicyForResponse):
+
 2011-07-01  Balazs Kelemen  <kbalazs@webkit.org>
 

trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp

@@ -602 +602 @@
         return;
 
-    if (!request.url().string())
-        return;
+    if (!request.url().string()) {
+        (m_frame->coreFrame()->loader()->policyChecker()->*function)(PolicyUse);
+        return;
+    }
 
     RefPtr<APIObject> userData;