Changeset 91346 in webkit

Timestamp:

Jul 20, 2011, 12:54:08 AM (15 years ago)

Author:

caseq@chromium.org

Message:

Source/WebCore: Add a resourceLink audit formatter to make it possible for devtools
extensions to link to specific lines in HTML/JS/CSS resources from the
audit results panel.

​https://bugs.webkit.org/show_bug.cgi?id=64315

Patch by Boris Smus <​smus@chromium.org> on 2011-07-20
Reviewed by Yury Semikhatsky.

• inspector/front-end/AuditFormatters.js: resourceLink implementation
• inspector/front-end/ExtensionAPI.js: registering resourceLink FormattedValue

LayoutTests: Web Inspector: audit extensions need a way to link directly to resources
​https://bugs.webkit.org/show_bug.cgi?id=64315

Patch by Boris Smus <​smus@chromium.org> on 2011-07-20
Reviewed by Yury Semikhatsky.

• inspector/extensions/extensions-audits-expected.txt:
• inspector/extensions/extensions-audits-api-expected.txt:
• inspector/extensions/extensions-audits.html:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/inspector/extensions/extensions-audits-api-expected.txt (modified) (1 diff)
• LayoutTests/inspector/extensions/extensions-audits-expected.txt (modified) (1 diff)
• LayoutTests/inspector/extensions/extensions-audits.html (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/inspector/front-end/AuditFormatters.js (modified) (1 diff)
• Source/WebCore/inspector/front-end/ExtensionAPI.js (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2011-07-20  Boris Smus  <smus@chromium.org>
+
+        Web Inspector: audit extensions need a way to link directly to resources
+        https://bugs.webkit.org/show_bug.cgi?id=64315
+
+        Reviewed by Yury Semikhatsky.
+
+        * inspector/extensions/extensions-audits-expected.txt:
+        * inspector/extensions/extensions-audits-api-expected.txt:
+        * inspector/extensions/extensions-audits.html:
+
 2011-07-20  tkent@chromium.org  <tkent@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
 

trunk/LayoutTests/inspector/extensions/extensions-audits-api-expected.txt

@@ -17 +17 @@
     createSnippet : <function>
     createText : <function>
+    createResourceLink : <function>
     addResult : <function>
     createResult : <function>

trunk/LayoutTests/inspector/extensions/extensions-audits-expected.txt

@@ -20 +20 @@
     return 4;
 }
+         error.html:10
     Passed rule
      this rule always passes ok

trunk/LayoutTests/inspector/extensions/extensions-audits.html

@@ -21 +21 @@
         nestedNode.expanded = true;
         nestedNode.addChild(results.createSnippet("function rand()\n{\n    return 4;\n}"));
+        nestedNode.addChild(results.createResourceLink('file:///path/to/error.html', 10));
 
         results.addResult("Rule with details subtree (1)", "This rule has a lot of details", results.Severity.Warning, node);

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-07-20  Boris Smus  <smus@chromium.org>
+
+        Add a resourceLink audit formatter to make it possible for devtools
+        extensions to link to specific lines in HTML/JS/CSS resources from the
+        audit results panel.
+
+        https://bugs.webkit.org/show_bug.cgi?id=64315
+
+        Reviewed by Yury Semikhatsky.
+
+        * inspector/front-end/AuditFormatters.js: resourceLink implementation
+        * inspector/front-end/ExtensionAPI.js: registering resourceLink FormattedValue
+
+
 2011-07-20  Kent Tamura  <tkent@chromium.org>
 

trunk/Source/WebCore/inspector/front-end/AuditFormatters.js

@@ -89 +89 @@
             a.target = "_blank";
         return a;
+    },
+
+    resourceLink: function(url, line)
+    {
+        var title = url.replace(/.*[\/\\]/, "") + ":" + line;
+        var a = document.createElement("a");
+        a.href = url;
+        a.title = url;
+        a.className = "console-message-url webkit-html-resource-link";
+        a.setAttribute("line_number", line);
+        a.setAttribute("preferred_panel", "scripts");
+        a.textContent = title;
+        return a;
     }
 };

trunk/Source/WebCore/inspector/front-end/ExtensionAPI.js

@@ -291 +291 @@
     this.createSnippet = bind(this._nodeFactory, null, "snippet");
     this.createText = bind(this._nodeFactory, null, "text");
+    this.createResourceLink = bind(this._nodeFactory, null, "resourceLink");
 }