Changeset 92152 in webkit

Timestamp:

Aug 1, 2011, 4:49:54 PM (15 years ago)

Author:

timothy_horton@apple.com

Message:

Severe shadow repaint issues with SVGText elements
​https://bugs.webkit.org/show_bug.cgi?id=63648
<rdar://problem/7632269>

Reviewed by Darin Adler.

Make SVG elements which inherit from RenderSVGBlock take text-shadow
overflow into account when determining whether or not they should draw

Test: svg/custom/repaint-shadow.svg

• rendering/RenderBox.h:

(WebCore::RenderBox::visualOverflowRect):

• rendering/svg/RenderSVGBlock.cpp:

(WebCore::RenderSVGBlock::visualOverflowRect):

• rendering/svg/RenderSVGBlock.h:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/mac/svg/custom/repaint-shadow-expected.png (added)
• LayoutTests/platform/mac/svg/custom/repaint-shadow-expected.txt (added)
• LayoutTests/svg/custom/repaint-shadow.svg (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/rendering/RenderBox.h (modified) (1 diff)
• Source/WebCore/rendering/svg/RenderSVGBlock.cpp (modified) (1 diff)
• Source/WebCore/rendering/svg/RenderSVGBlock.h (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2011-08-01  Tim Horton  <timothy_horton@apple.com>
+
+        Severe shadow repaint issues with SVGText elements
+        https://bugs.webkit.org/show_bug.cgi?id=63648
+        <rdar://problem/7632269>
+
+        Reviewed by Darin Adler.
+
+        Make SVG elements which inherit from RenderSVGBlock take text-shadow
+        overflow into account when determining whether or not they should draw
+
+        * platform/mac/svg/custom/repaint-shadow-expected.png: Added.
+        * platform/mac/svg/custom/repaint-shadow-expected.txt: Added.
+        * svg/custom/repaint-shadow.svg: Added.
+
 2011-08-01  Chris Rogers  <crogers@google.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-08-01  Tim Horton  <timothy_horton@apple.com>
+
+        Severe shadow repaint issues with SVGText elements
+        https://bugs.webkit.org/show_bug.cgi?id=63648
+        <rdar://problem/7632269>
+
+        Reviewed by Darin Adler.
+
+        Make SVG elements which inherit from RenderSVGBlock take text-shadow
+        overflow into account when determining whether or not they should draw
+
+        Test: svg/custom/repaint-shadow.svg
+
+        * rendering/RenderBox.h:
+        (WebCore::RenderBox::visualOverflowRect):
+        * rendering/svg/RenderSVGBlock.cpp:
+        (WebCore::RenderSVGBlock::visualOverflowRect):
+        * rendering/svg/RenderSVGBlock.h:
+
 2011-08-01  Zhenyao Mo  <zmo@google.com>
 

trunk/Source/WebCore/rendering/RenderBox.h

@@ -149 +149 @@
     LayoutUnit logicalRightLayoutOverflow() const { return style()->isHorizontalWritingMode() ? maxXLayoutOverflow() : maxYLayoutOverflow(); }
     
-    LayoutRect visualOverflowRect() const { return m_overflow ? m_overflow->visualOverflowRect() : borderBoxRect(); }
+    virtual LayoutRect visualOverflowRect() const { return m_overflow ? m_overflow->visualOverflowRect() : borderBoxRect(); }
     LayoutUnit minYVisualOverflow() const { return m_overflow? m_overflow->minYVisualOverflow() : 0; }
     LayoutUnit maxYVisualOverflow() const { return m_overflow ? m_overflow->maxYVisualOverflow() : height(); }

trunk/Source/WebCore/rendering/svg/RenderSVGBlock.cpp

@@ -33 +33 @@
     : RenderBlock(node)
 {
+}
+
+IntRect RenderSVGBlock::visualOverflowRect() const
+{
+    LayoutRect borderRect = borderBoxRect();
+
+    if (const ShadowData* textShadow = style()->textShadow())
+        textShadow->adjustRectForShadow(borderRect);
+
+    return borderRect;
 }
 

trunk/Source/WebCore/rendering/svg/RenderSVGBlock.h

@@ -33 +33 @@
     explicit RenderSVGBlock(SVGElement*);
 
+    virtual IntRect visualOverflowRect() const;
+
 private:
     virtual void setStyle(PassRefPtr<RenderStyle>);