Changeset 93726 in webkit


Ignore:
Timestamp:
Aug 24, 2011, 1:16:45 PM (14 years ago)
Author:
Nate Chapin
Message:

2011-08-24 Nate Chapin <Nate Chapin>

Fix an intermittent crash in EventSource, when a
reconnect timer triggers after a navigation
away from the current page begins.
​https://bugs.webkit.org/show_bug.cgi?id=45202

Reviewed by Alexey Proskuryakov.

Test: http/tests/eventsource/eventsource-reconnect-during-navigate-crash.html

  • page/EventSource.cpp: (WebCore::EventSource::connect): Don't set m_requestInFlight

to true if ThreadableLoader::create() failed.

Location:
trunk
Files:
3 added
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r93722 r93726  
     12011-08-24  Nate Chapin  <japhet@chromium.org>
     2
     3        Test for https://bugs.webkit.org/show_bug.cgi?id=45202.
     4
     5        Reviewed by Alexey Proskuryakov.
     6
     7        * http/tests/eventsource/eventsource-reconnect-during-navigate-crash-expected.txt: Added.
     8        * http/tests/eventsource/eventsource-reconnect-during-navigate-crash.html: Added.
     9        * http/tests/eventsource/resources/wait-then-notify-done.php: Added.
     10
    1112011-08-23  Peter Kasting  <pkasting@google.com>
    212

  • trunk/Source/WebCore/ChangeLog

    r93725 r93726  
     12011-08-24  Nate Chapin  <japhet@chromium.org>
     2
     3        Fix an intermittent crash in EventSource, when a
     4        reconnect timer triggers after a navigation
     5        away from the current page begins.
     6        https://bugs.webkit.org/show_bug.cgi?id=45202
     7
     8        Reviewed by Alexey Proskuryakov.
     9
     10        Test: http/tests/eventsource/eventsource-reconnect-during-navigate-crash.html
     11
     12        * page/EventSource.cpp:
     13        (WebCore::EventSource::connect): Don't set m_requestInFlight
     14            to true if ThreadableLoader::create() failed.
     15
    1162011-08-24  Mike Reed  <reed@google.com>
    217

  • trunk/Source/WebCore/page/EventSource.cpp

    r92991 r93726  
    121121    m_loader = ThreadableLoader::create(scriptExecutionContext(), this, request, options);
    122122
    123     m_requestInFlight = true;
     123    if (m_loader)
     124        m_requestInFlight = true;
    124125}
    125126
Note: See TracChangeset for help on using the changeset viewer.