Changeset 94002 in webkit

Timestamp:

Aug 29, 2011, 12:23:00 PM (15 years ago)

Author:

commit-queue@webkit.org

Message:

Source/WebCore: Fix failures when FFT size is changed.
​https://bugs.webkit.org/show_bug.cgi?id=66916

Patch by Chris Palmer <​palmer@google.com> on 2011-08-29
Reviewed by Kenneth Russell.

Test: webaudio/fft-sizing.html

• webaudio/RealtimeAnalyser.cpp:

(WebCore::RealtimeAnalyser::setFftSize): Assert size sanity.
(WebCore::RealtimeAnalyser::doFFTAnalysis): Iterate the correct number of times over magnitudeBuffer.

• webaudio/RealtimeAnalyser.h: Put member fields in the correct order (Min before Max).

LayoutTests: Fix failures when FFT array size is changed.
​https://bugs.webkit.org/show_bug.cgi?id=66916

Patch by Chris Palmer <​palmer@google.com> on 2011-08-29
Reviewed by Kenneth Russell.

• webaudio/realtimeanalyser-fft-sizing-expected.txt: Added.
• webaudio/realtimeanalyser-fft-sizing.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/webaudio/realtimeanalyser-fft-sizing-expected.txt (added)
• LayoutTests/webaudio/realtimeanalyser-fft-sizing.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/webaudio/RealtimeAnalyser.cpp (modified) (5 diffs)
• Source/WebCore/webaudio/RealtimeAnalyser.h (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2011-08-29  Chris Palmer  <palmer@google.com>
+
+        Fix failures when FFT array size is changed.
+        https://bugs.webkit.org/show_bug.cgi?id=66916
+
+        Reviewed by Kenneth Russell.
+
+        * webaudio/realtimeanalyser-fft-sizing-expected.txt: Added.
+        * webaudio/realtimeanalyser-fft-sizing.html: Added.
+
 2011-08-29  Abhishek Arya  <inferno@chromium.org>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-08-29  Chris Palmer  <palmer@google.com>
+
+        Fix failures when FFT size is changed.
+        https://bugs.webkit.org/show_bug.cgi?id=66916
+
+        Reviewed by Kenneth Russell.
+
+        Test: webaudio/fft-sizing.html
+
+        * webaudio/RealtimeAnalyser.cpp:
+        (WebCore::RealtimeAnalyser::setFftSize): Assert size sanity.
+        (WebCore::RealtimeAnalyser::doFFTAnalysis): Iterate the correct number of times over magnitudeBuffer.
+        * webaudio/RealtimeAnalyser.h: Put member fields in the correct order (Min before Max).
+
 2011-08-29  Abhishek Arya  <inferno@chromium.org>
 

trunk/Source/WebCore/webaudio/RealtimeAnalyser.cpp

@@ -50 +50 @@
 
 const unsigned RealtimeAnalyser::DefaultFFTSize = 2048;
+// All FFT implementations are expected to handle power-of-two sizes MinFFTSize <= size <= MaxFFTSize.
+const unsigned RealtimeAnalyser::MinFFTSize = 128;
 const unsigned RealtimeAnalyser::MaxFFTSize = 2048;
 const unsigned RealtimeAnalyser::InputBufferSize = RealtimeAnalyser::MaxFFTSize * 2;
@@ -83 +85 @@
     unsigned log2size = static_cast<unsigned>(log2(size));
     bool isPOT(1UL << log2size == size);
-    
-    if (!isPOT || size > MaxFFTSize) {
+
+    if (!isPOT || size > MaxFFTSize || size < MinFFTSize) {
         // FIXME: It would be good to also set an exception.
         return;
@@ -90 +92 @@
 
     if (m_fftSize != size) {
-        m_analysisFrame = adoptPtr(new FFTFrame(m_fftSize));
-        m_magnitudeBuffer.allocate(size);
+        m_analysisFrame = adoptPtr(new FFTFrame(size));
+        // m_magnitudeBuffer has size = fftSize / 2 because it contains floats reduced from complex values in m_analysisFrame.
+        m_magnitudeBuffer.allocate(size / 2);
         m_fftSize = size;
     }
@@ -166 +169 @@
     m_analysisFrame->doFFT(tempP);
 
-    size_t n = DefaultFFTSize / 2;
-
     float* realP = m_analysisFrame->realData();
     float* imagP = m_analysisFrame->imagData();
@@ -184 +185 @@
     // Convert the analysis data from complex to magnitude and average with the previous result.
     float* destination = magnitudeBuffer().data();
-    for (unsigned i = 0; i < n; ++i) {
+    size_t n = magnitudeBuffer().size();
+    for (size_t i = 0; i < n; ++i) {
         Complex c(realP[i], imagP[i]);
         double scalarMagnitude = abs(c) * MagnitudeScale;        

trunk/Source/WebCore/webaudio/RealtimeAnalyser.h

@@ -71 +71 @@
 
     static const unsigned DefaultFFTSize;
+    static const unsigned MinFFTSize;
     static const unsigned MaxFFTSize;
     static const unsigned InputBufferSize;