Changeset 94019 in webkit

Timestamp:

Aug 29, 2011, 2:57:09 PM (15 years ago)

Author:

caryclark@google.com

Message:

Only enable font smoothing as requested (Skia on Mac)
​https://bugs.webkit.org/show_bug.cgi?id=67143

This adjusts LayoutTest pixel output to more closely
match other platforms.

Reviewed by Kenneth Russell.

No new tests. This platform is not yet enabled.

• platform/graphics/skia/FontSkia.cpp:

(WebCore::setupPaint):
LCD text was always enabled to test the code path. With this change,
it is only enabled when instructed by the font state.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/skia/FontSkia.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-08-29  Cary Clark  <caryclark@google.com>
+
+        Only enable font smoothing as requested (Skia on Mac)
+        https://bugs.webkit.org/show_bug.cgi?id=67143
+
+        This adjusts LayoutTest pixel output to more closely
+        match other platforms.
+
+        Reviewed by Kenneth Russell.
+
+        No new tests. This platform is not yet enabled.
+
+        * platform/graphics/skia/FontSkia.cpp:
+        (WebCore::setupPaint):
+        LCD text was always enabled to test the code path. With this change,
+        it is only enabled when instructed by the font state.
+
 2011-08-29  Julien Chaffraix  <jchaffraix@webkit.org>
 

trunk/Source/WebCore/platform/graphics/skia/FontSkia.cpp

@@ -88 +88 @@
     paint->setTextSkewX(platformData.m_syntheticOblique ? -SK_Scalar1 / 4 : 0);
     paint->setAutohinted(false); // freetype specific
-    paint->setLCDRenderText(true); // font->fontDescription().fontSmoothing() == SubpixelAntialiased);
+    paint->setLCDRenderText(font->fontDescription().fontSmoothing() == SubpixelAntialiased);
 }