Changeset 94038 in webkit

Timestamp:

Aug 29, 2011, 7:03:52 PM (15 years ago)

Author:

rniwa@webkit.org

Message:

Add a test for lastChangeWasUserEdit in HTMLInputElement and HTMLTextAreaElement
​https://bugs.webkit.org/show_bug.cgi?id=67173

Reviewed by Darin Adler.

Source/WebCore:

Exposed HTMLInputElement::lastChangeWasUserEdit and HTMLTextAreaElement::lastChangeWasUserEdit
via internals.wasLastChangeUserEdit(Element*, ExceptionCode&). The first argument must be
an input element or a textarea element lastChangeWasUserEdit is called upon.

Test: fast/forms/textfield-lastchange-was-useredit.html

• testing/Internals.cpp:

(WebCore::Internals::wasLastChangeUserEdit):

• testing/Internals.h:
• testing/Internals.idl:

LayoutTests:

Added some basic test for HTMLInputElement::lastChangeWasUserEdit and
HTMLTextAreaElement::lastChangeWasUserEdit.

• fast/forms/textfield-lastchange-was-useredit-expected.txt: Added.
• fast/forms/textfield-lastchange-was-useredit.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/forms/textfield-lastchange-was-useredit-expected.txt (added)
• LayoutTests/fast/forms/textfield-lastchange-was-useredit.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/testing/Internals.cpp (modified) (2 diffs)
• Source/WebCore/testing/Internals.h (modified) (1 diff)
• Source/WebCore/testing/Internals.idl (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2011-08-29  Ryosuke Niwa  <rniwa@webkit.org>
+
+        Add a test for lastChangeWasUserEdit in HTMLInputElement and HTMLTextAreaElement
+        https://bugs.webkit.org/show_bug.cgi?id=67173
+
+        Reviewed by Darin Adler.
+
+        Added some basic test for HTMLInputElement::lastChangeWasUserEdit and
+        HTMLTextAreaElement::lastChangeWasUserEdit.
+
+        * fast/forms/textfield-lastchange-was-useredit-expected.txt: Added.
+        * fast/forms/textfield-lastchange-was-useredit.html: Added.
+
 2011-08-29  Kenji Imasaki  <imasaki@chromium.org>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-08-29  Ryosuke Niwa  <rniwa@webkit.org>
+
+        Add a test for lastChangeWasUserEdit in HTMLInputElement and HTMLTextAreaElement
+        https://bugs.webkit.org/show_bug.cgi?id=67173
+
+        Reviewed by Darin Adler.
+
+        Exposed HTMLInputElement::lastChangeWasUserEdit and HTMLTextAreaElement::lastChangeWasUserEdit
+        via internals.wasLastChangeUserEdit(Element*, ExceptionCode&). The first argument must be
+        an input element or a textarea element lastChangeWasUserEdit is called upon.
+
+        Test: fast/forms/textfield-lastchange-was-useredit.html
+
+        * testing/Internals.cpp:
+        (WebCore::Internals::wasLastChangeUserEdit):
+        * testing/Internals.h:
+        * testing/Internals.idl:
+
 2011-08-29  Luke Macpherson   <macpherson@chromium.org>
 

trunk/Source/WebCore/testing/Internals.cpp

@@ -33 +33 @@
 #include "Element.h"
 #include "ExceptionCode.h"
+#include "HTMLInputElement.h"
+#include "HTMLNames.h"
+#include "HTMLTextAreaElement.h"
 #include "InspectorController.h"
 #include "MemoryCache.h"
@@ -263 +266 @@
 }
 
-}
-
+bool Internals::wasLastChangeUserEdit(Element* textField, ExceptionCode& ec)
+{
+    if (!textField) {
+        ec = INVALID_ACCESS_ERR;
+        return false;
+    }
+
+    if (textField->hasTagName(HTMLNames::inputTag))
+        return static_cast<HTMLInputElement*>(textField)->lastChangeWasUserEdit();
+
+    if (textField->hasTagName(HTMLNames::textareaTag))
+        return static_cast<HTMLTextAreaElement*>(textField)->lastChangeWasUserEdit();
+
+    ec = INVALID_NODE_TYPE_ERR;
+    return false;
+}
+
+}
+

trunk/Source/WebCore/testing/Internals.h

@@ -77 +77 @@
     void setPasswordEchoDurationInSeconds(Document*, double durationInSeconds, ExceptionCode&);
 
+    bool wasLastChangeUserEdit(Element* textField, ExceptionCode&);
+
     static const char* internalsId;
 

trunk/Source/WebCore/testing/Internals.idl

@@ -50 +50 @@
         void setPasswordEchoEnabled(in Document document, in boolean enabled) raises(DOMException);
         void setPasswordEchoDurationInSeconds(in Document document, in double durationInSeconds) raises(DOMException);
+
+        boolean wasLastChangeUserEdit(in Element textField) raises (DOMException);
     };
 }