Changeset 94044 in webkit

Timestamp:

Aug 29, 2011, 10:01:47 PM (15 years ago)

Author:

dbates@webkit.org

Message:

Add HAVE(VASPRINTF) macro to test for vasprintf() support
​https://bugs.webkit.org/show_bug.cgi?id=67156

Reviewed by Darin Adler.

Source/JavaScriptCore:

Encapsulate testing of vasprintf() support in a HAVE macro
instead of hardcoding the list of supported/unsupported
compilers at the call site.

• wtf/Platform.h:

Source/WebCore:

• xml/parser/XMLDocumentParserLibxml2.cpp:

(WebCore::XMLDocumentParser::error): Modified to use HAVE(VASPRINTF).

Location:

trunk/Source

Files:

• JavaScriptCore/ChangeLog (modified) (1 diff)
• JavaScriptCore/wtf/Platform.h (modified) (1 diff)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/xml/parser/XMLDocumentParserLibxml2.cpp (modified) (2 diffs)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2011-08-29  Daniel Bates  <dbates@webkit.org>
+
+        Add HAVE(VASPRINTF) macro to test for vasprintf() support
+        https://bugs.webkit.org/show_bug.cgi?id=67156
+
+        Reviewed by Darin Adler.
+
+        Encapsulate testing of vasprintf() support in a HAVE macro
+        instead of hardcoding the list of supported/unsupported
+        compilers at the call site.
+
+        * wtf/Platform.h:
+
 2011-08-29  Mark Hahnenberg  <mhahnenberg@apple.com>
 

trunk/Source/JavaScriptCore/wtf/Platform.h

@@ -682 +682 @@
 #endif
 
+#if !defined(HAVE_VASPRINTF)
+#if !COMPILER(MSVC) && !COMPILER(RVCT) && !COMPILER(MINGW)
+#define HAVE_VASPRINTF 1
+#endif
+#endif
+
 #if !defined(HAVE_STRNSTR)
 #if OS(DARWIN) || OS(FREEBSD)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-08-29  Daniel Bates  <dbates@webkit.org>
+
+        Add HAVE(VASPRINTF) macro to test for vasprintf() support
+        https://bugs.webkit.org/show_bug.cgi?id=67156
+
+        Reviewed by Darin Adler.
+
+        * xml/parser/XMLDocumentParserLibxml2.cpp:
+        (WebCore::XMLDocumentParser::error): Modified to use HAVE(VASPRINTF).
+
 2011-08-29  Yuta Kitamura  <yutak@chromium.org>
 

trunk/Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp

@@ -939 +939 @@
         return;
 
-#if COMPILER(MSVC) || COMPILER(RVCT) || COMPILER(MINGW)
+#if HAVE(VASPRINTF)
+    char* m;
+    if (vasprintf(&m, message, args) == -1)
+        return;
+#else
     char m[1024];
     vsnprintf(m, sizeof(m) - 1, message, args);
-#else
-    char* m;
-    if (vasprintf(&m, message, args) == -1)
-        return;
 #endif
 
@@ -953 +953 @@
         handleError(type, m, lineNumber(), columnNumber());
 
-#if !COMPILER(MSVC) && !COMPILER(RVCT) && !COMPILER(MINGW)
+#if HAVE(VASPRINTF)
     free(m);
 #endif